Skip to content

Commit

Permalink
Add IDD bounds for ManualGrid (can't be used) for completeness
Browse files Browse the repository at this point in the history 
The reason I'm not just adding an IDD bound for BaseDepth in EquivAutogrid is that the error would be cryptic versus specifically explaining why with a fatal
  • Loading branch information
@jmarrec
jmarrec committed Dec 11, 2024
1 parent c946eba commit 1eeccdb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions idd/BasementGHT.idd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ ManualGrid,
\required-field
N4, \field NZBG: Number of cells in Z direction. below grade: 10-35]
\minimum 1
\maximum 100
\required-field
N5, \field IBASE: X direction cell indicator of slab edge: 5-20]
\required-field
Expand Down

3 comments on commit 1eeccdb

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10847-Basement_BaseDepthCrash (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2: OK (2921 of 2921 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10847-Basement_BaseDepthCrash (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-UnitTestsCoverage-RelWithDebInfo: OK (2103 of 2103 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10847-Basement_BaseDepthCrash (jmarrec) - x86_64-Linux-Ubuntu-24.04-gcc-13.2-IntegrationCoverage-RelWithDebInfo: OK (801 of 801 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.