Schedule API #10848

amirroth · 2024-12-06T16:06:02Z

Pull request overview

Details forthcoming. Just testing for now.
Fixes #10869

github-actions · 2024-12-06T16:58:18Z

⚠️ Regressions detected on macos-14 for commit `4d72d8a`

Regression Summary

Audit: 668
EIO: 573
ERR: 669
EDD: 26
MTD: 5
Table Big Diffs: 490
Table String Diffs: 388
RDD: 9
MTR Big Diffs: 6
SSZ Big Diffs: 1
ZSZ Big Diffs: 2
PERF_LOG: 2
ESO Small Diffs: 23
MTR Small Diffs: 16
Table Small Diffs: 4
SSZ Small Diffs: 6
ESO Big Diffs: 6
ZSZ Small Diffs: 5

rraustad · 2024-12-06T17:28:20Z

src/EnergyPlus/ScheduleManager.cc

+        auto &s_sched = state.dataSched;
+        for (int i = 0; i < (int)s_sched->scheduleTypes.size(); ++i) if (s_sched->scheduleTypes[i]->Name == name) return i;
+        return -1;
+    }


[src/EnergyPlus/ScheduleManager.cc:99]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:227]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:241]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:273]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:385]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2409]:(style),[constParameterReference],Parameter 'state' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2497]:(style),[constParameterReference],Parameter 'state' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2502]:(style),[constParameterReference],Parameter 'state' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2515]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2553]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2587]:(style),[constVariableReference],Variable 's_sched' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2725]:(style),[constParameterReference],Parameter 'state' can be declared as reference to const
[src/EnergyPlus/ScheduleManager.cc:2978]:(style),[constVariableReference],Variable 's_glob' can be declared as reference to const

rraustad · 2024-12-06T18:44:00Z

I noticed that Schedule Value was added to the rdd for 1ZoneUncontrolled_win_1.idf. There are no schedules in that file. There is a ScheduleTypeLimits object.

 Zone,Average,Zone Humidity Index []
+Zone,Average,Schedule Value []
 HVAC,Sum,Environmental Impact Total N2O Emissions Carbon Equivalent Mass [kg]

ScheduleTypeLimits,
  Fraction,                !- Name
  0.0,                     !- Lower Limit Value
  1.0,                     !- Upper Limit Value
  CONTINUOUS;              !- Numeric Type

The error file shows there are 2 unused schedules:

    ************* Simulation Error Summary *************
+   ************* There are 2 unused schedules in input.
+   ************* Use Output:Diagnostics,DisplayUnusedSchedules; to see them.
    ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.

amirroth · 2024-12-06T19:44:27Z

I noticed that Schedule Value was added to the rdd for 1ZoneUncontrolled_win_1.idf. There are no schedules in that file. There is a ScheduleTypeLimits object.

 Zone,Average,Zone Humidity Index []
+Zone,Average,Schedule Value []
 HVAC,Sum,Environmental Impact Total N2O Emissions Carbon Equivalent Mass [kg]

ScheduleTypeLimits,
  Fraction,                !- Name
  0.0,                     !- Lower Limit Value
  1.0,                     !- Upper Limit Value
  CONTINUOUS;              !- Numeric Type

The error file shows there are 2 unused schedules:

    ************* Simulation Error Summary *************
+   ************* There are 2 unused schedules in input.
+   ************* Use Output:Diagnostics,DisplayUnusedSchedules; to see them.
    ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.

Hmmmm. I think I know what this is, but I will verify after I am done looking at something more serious. In this refactor, schedule 0 (always off) and schedule -1 (always on) are not schedule indices, they are actual schedule objects. This change was needed in order to allow schedules to be accessed as objects rather than via indices. These schedule objects are always created and its possible that this error is printed if they are not used.

github-actions · 2024-12-07T21:32:59Z

⚠️ Regressions detected on macos-14 for commit `b8e50a6`

Regression Summary

Audit: 693
EIO: 599
ERR: 694
EDD: 13
MTD: 4
Table Big Diffs: 518
Table String Diffs: 409
RDD: 9
ESO Big Diffs: 27
PERF_LOG: 2
ESO Small Diffs: 20
MTR Small Diffs: 13
Table Small Diffs: 4
MTR Big Diffs: 23
SSZ Small Diffs: 5
ZSZ Big Diffs: 1
ZSZ Small Diffs: 4

github-actions · 2024-12-08T17:18:37Z

⚠️ Regressions detected on macos-14 for commit `19a54ba`

Regression Summary

Audit: 742
EIO: 644
ERR: 744
EDD: 31
MTD: 6
Table Big Diffs: 559
Table String Diffs: 447
RDD: 10
ESO Big Diffs: 32
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
ESO Small Diffs: 27
MTR Small Diffs: 17
SSZ Big Diffs: 4
MTR Big Diffs: 30
PERF_LOG: 3
Table Small Diffs: 3

github-actions · 2024-12-09T19:23:01Z

⚠️ Regressions detected on macos-14 for commit `2f6289a`

Regression Summary

Audit: 760
EIO: 400
EDD: 33
MTD: 6
Table Big Diffs: 45
Table String Diffs: 377
ERR: 354
RDD: 10
ESO Big Diffs: 31
Table Small Diffs: 43
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
ESO Small Diffs: 31
MTR Small Diffs: 20
SSZ Big Diffs: 4
MTR Big Diffs: 29
PERF_LOG: 3

github-actions · 2024-12-09T23:31:23Z

⚠️ Regressions detected on macos-14 for commit `faf2d8b`

Regression Summary

EIO: 449
EDD: 33
Table Big Diffs: 147
Table String Diffs: 425
ERR: 370
ESO Big Diffs: 148
Table Small Diffs: 45
MTR Big Diffs: 132
Audit: 2
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
SSZ Big Diffs: 4
MTR Small Diffs: 3
PERF_LOG: 3
ESO Small Diffs: 7
JSON Big Diffs: 1

github-actions · 2024-12-10T16:10:03Z

⚠️ Regressions detected on macos-14 for commit `2d9f415`

Regression Summary

EIO: 186
EDD: 33
Table Big Diffs: 146
Table String Diffs: 401
ERR: 133
Table Small Diffs: 45
ESO Big Diffs: 145
MTR Big Diffs: 130
Audit: 2
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
SSZ Big Diffs: 4
MTR Small Diffs: 3
PERF_LOG: 2
ESO Small Diffs: 7
JSON Big Diffs: 1

github-actions · 2024-12-11T02:51:50Z

⚠️ Regressions detected on macos-14 for commit `f2c5bbe`

Regression Summary

EIO: 185
EDD: 33
Table Big Diffs: 144
Table String Diffs: 401
ERR: 133
Table Small Diffs: 46
ESO Big Diffs: 146
MTR Big Diffs: 131
Audit: 2
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
SSZ Big Diffs: 4
MTR Small Diffs: 3
PERF_LOG: 2
ESO Small Diffs: 7
JSON Big Diffs: 1

…e vectors and not just arrays

github-actions · 2024-12-11T19:31:50Z

⚠️ Regressions detected on macos-14 for commit `27cf685`

Regression Summary

EIO: 184
EDD: 33
Table Big Diffs: 143
Table String Diffs: 402
ERR: 136
Table Small Diffs: 45
ESO Big Diffs: 145
MTR Big Diffs: 130
Audit: 2
SSZ Small Diffs: 2
ZSZ Big Diffs: 6
SSZ Big Diffs: 4
MTR Small Diffs: 3
PERF_LOG: 2
ESO Small Diffs: 7
JSON Big Diffs: 1
MTD: 1

github-actions · 2024-12-11T21:51:34Z

⚠️ Regressions detected on macos-14 for commit `07edd4f`

Regression Summary

EIO: 185
EDD: 33
Table Big Diffs: 145
Table String Diffs: 402
ERR: 135
Table Small Diffs: 45
ESO Big Diffs: 146
MTR Big Diffs: 132
Audit: 2
SSZ Small Diffs: 2
ZSZ Big Diffs: 7
SSZ Big Diffs: 4
MTR Small Diffs: 3
PERF_LOG: 2
ESO Small Diffs: 7
JSON Big Diffs: 1

github-actions · 2024-12-12T21:08:16Z

⚠️ Regressions detected on macos-14 for commit `e0d5bc5`

Regression Summary

EIO: 194
EDD: 34
Table Big Diffs: 151
Table String Diffs: 415
ERR: 145
Table Small Diffs: 45
ESO Big Diffs: 150
MTR Big Diffs: 138
Audit: 5
SSZ Small Diffs: 2
ZSZ Big Diffs: 11
SSZ Big Diffs: 7
MTR Small Diffs: 4
PERF_LOG: 3
ESO Small Diffs: 8
JSON Big Diffs: 1

rraustad · 2024-12-14T21:00:36Z

Diff in the OCCUPY-1 schedule in many files:

rraustad · 2024-12-14T21:37:21Z

Hmm, there is no Zone Minimum CO2 Concentration schedule in DOAToPTHP or DOAToUnitarySystem so these files don't run in this branch. There is also no Controller:MechanicalVentilation object in these files.

ZoneControl:ContaminantController,
  A5 , \field Minimum Carbon Dioxide Concentration Schedule Name
    \type object-list
    \object-list ScheduleNames
    \note Schedule values should be carbon dioxide concentration in parts per
    \note million (ppm)
    \note This field is used when the field System Outdoor Air Method =
    \note ProportionalControlBasedOnOccupancySchedule or ProportionalControlBasedOnDesignOccupancy,
    \note or ProportionalControlBasedOnDesignOARate in Controller:MechanicalVentilation


** Severe  ** GetZoneContaminantSetPoints: ZoneControl:ContaminantController = SPACE1-1 CONTAMINANT CONTROLLER
**   ~~~   ** Minimum Carbon Dioxide Concentration Schedule Name = ZONE MINIMUM CO2 CONCENTRATION, item not found.

ZoneControl:ContaminantController,
  SPACE1-1 Contaminant Controller,  !- Name
  SPACE1-1,                !- Zone Name
  HVACTemplate-Always 1,   !- Carbon Dioxide Control Availability Schedule Name
  Zone Setpoint CO2 Concentration,  !- Carbon Dioxide Setpoint Schedule Name
  Zone Minimum CO2 Concentration;  !- Minimum Carbon Dioxide Concentration Schedule Name

amirroth · 2024-12-15T13:29:05Z

Hmm, there is no Zone Minimum CO2 Concentration schedule in DOAToPTHP or DOAToUnitarySystem so these files don't run in this branch. There is also no Controller:MechanicalVentilation object in these files.

ZoneControl:ContaminantController,
  A5 , \field Minimum Carbon Dioxide Concentration Schedule Name
    \type object-list
    \object-list ScheduleNames
    \note Schedule values should be carbon dioxide concentration in parts per
    \note million (ppm)
    \note This field is used when the field System Outdoor Air Method =
    \note ProportionalControlBasedOnOccupancySchedule or ProportionalControlBasedOnDesignOccupancy,
    \note or ProportionalControlBasedOnDesignOARate in Controller:MechanicalVentilation


** Severe  ** GetZoneContaminantSetPoints: ZoneControl:ContaminantController = SPACE1-1 CONTAMINANT CONTROLLER
**   ~~~   ** Minimum Carbon Dioxide Concentration Schedule Name = ZONE MINIMUM CO2 CONCENTRATION, item not found.

ZoneControl:ContaminantController,
  SPACE1-1 Contaminant Controller,  !- Name
  SPACE1-1,                !- Zone Name
  HVACTemplate-Always 1,   !- Carbon Dioxide Control Availability Schedule Name
  Zone Setpoint CO2 Concentration,  !- Carbon Dioxide Setpoint Schedule Name
  Zone Minimum CO2 Concentration;  !- Minimum Carbon Dioxide Concentration Schedule Name

Correct. Why is okay for this object to refer to schedules that don't exist but not okay for any other object?

amirroth · 2024-12-15T17:52:32Z

Diff in the OCCUPY-1 schedule in many files:

This does not reproduce locally on macos. The actual value is 2479.5 on both develop and scheduleAPI branch and rounds up to 2480. on both. Maybe on Windows or another system one of the values actually computes as 2479.4999999999 and rounds down? develop does a sum on all schedule values during this calculation while scheduleAPI does a sum on day schedule values first and then sums those, so a change in order of floating-point operations often results in issues like these. Not sure there is a real issue here other than just spurious diffs that need to be sorted through. 🤷

github-actions · 2024-12-16T17:54:36Z

⚠️ Regressions detected on macos-14 for commit `483072d`

Regression Summary

EIO: 69
EDD: 34
Table Big Diffs: 10
Table String Diffs: 329
ERR: 54
Table Small Diffs: 51
ESO Small Diffs: 39
MTR Small Diffs: 32
ESO Big Diffs: 4
SSZ Small Diffs: 1
ZSZ Big Diffs: 1
PERF_LOG: 1

github-actions · 2024-12-18T03:23:17Z

⚠️ Regressions detected on macos-14 for commit `c376533`

Regression Summary

EIO: 67
EDD: 34
Table Big Diffs: 8
Table String Diffs: 329
ERR: 54
Table Small Diffs: 51
ESO Small Diffs: 39
MTR Small Diffs: 32
SSZ Small Diffs: 1
ZSZ Big Diffs: 1
ESO Big Diffs: 1
PERF_LOG: 1

github-actions · 2024-12-19T00:47:24Z

⚠️ Regressions detected on macos-14 for commit `aa49c0d`

Regression Summary

EIO: 66
EDD: 34
Table Big Diffs: 8
Table String Diffs: 329
ERR: 54
Table Small Diffs: 51
ESO Small Diffs: 39
MTR Small Diffs: 32
SSZ Small Diffs: 1
ZSZ Big Diffs: 1
ESO Big Diffs: 1
PERF_LOG: 1

rraustad · 2024-12-19T15:37:21Z

1ZoneDataCenterCRAC_* all show the same diff with ITE equipment. I would think the Max would show a non-zero number but it depends on the schedules for those day types. These 8 day types show diffs in the min/max. For all these to show 0 -> 50000 seems like a need to investigate.

  ElectricEquipment:ITE:AirCooled,
    Data Center Servers,     !- Name
    Main Zone,               !- Zone or Space Name
    FlowControlWithApproachTemperatures,  !- Air Flow Calculation Method
    Watts/Unit,              !- Design Power Input Calculation Method
    500,                     !- Watts per Unit {W}
    100,                     !- Number of Units
    ,                        !- Watts per Zone Floor Area {W/m2}
    Data Center Operation Schedule,  !- Design Power Input Schedule Name

And then I saw this and think this branch fixed something:

Schedule:Constant,Data Center Operation Schedule,Any Number,1.0;

These 8 days types show diffs:

Minimum Equipment Level for Weekdays {W}, Maximum Equipment Level for Weekdays {W},Minimum Equipment Level for Weekends/Holidays {W}, Maximum Equipment Level for Weekends /Holidays {W},Minimum Equipment Level for Summer Design Days {W}, Maximum Equipment Level for Summer Design Days {W},Minimum Equipment Level for Winter Design Days {W}, Maximum Equipment Level for Winter Design Days {W}

 ! <ElectricEquipment:ITE:AirCooled Internal Gains Nominal>,Name,Schedule Name,Zone Name,Zone Floor Area {m2},# Zone Occupants,Equipment Level {W},Equipment/Floor Area {W/m2},Equipment per person {W/person},Fraction Convected,CPU End-Use SubCategory,Fan End-Use SubCategory,UPS End-Use SubCategory,Minimum Equipment Level for All Day Types {W},Maximum Equipment Level for All Day Types {W},Minimum Equipment Level for Weekdays {W}, Maximum Equipment Level for Weekdays {W},Minimum Equipment Level for Weekends/Holidays {W}, Maximum Equipment Level for Weekends /Holidays {W},Minimum Equipment Level for Summer Design Days {W}, Maximum Equipment Level for Summer Design Days {W},Minimum Equipment Level for Winter Design Days {W}, Maximum Equipment Level for Winter Design Days {W},Design Air Volume Flow Rate {m3/s}
- ElectricEquipment:ITE:AirCooled Internal Gains Nominal, DATA CENTER SERVERS,DATA CENTER OPERATION SCHEDULE,MAIN ZONE,232.26,0.0,50000.000,215.278,N/A,1.0,ITE-CPU,ITE-Fans,ITE-UPS,5000.000,50000.000,0.000,0.000,0.000,0.000,0.000,0.000,0.000,0.000,5.0000000000
+ ElectricEquipment:ITE:AirCooled Internal Gains Nominal, DATA CENTER SERVERS,DATA CENTER OPERATION SCHEDULE,MAIN ZONE,232.26,0.0,50000.000,215.278,N/A,1.0,ITE-CPU,ITE-Fans,ITE-UPS,5000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,5.0000000000

amirroth · 2024-12-19T16:15:45Z

1ZoneDataCenterCRAC_* all show the same diff with ITE equipment. I would think the Max would show a non-zero number but it depends on the schedules for those day types. These 8 day types show diffs in the min/max. For all these to show 0 -> 50000 seems like a need to investigate.

  ElectricEquipment:ITE:AirCooled,
    Data Center Servers,     !- Name
    Main Zone,               !- Zone or Space Name
    FlowControlWithApproachTemperatures,  !- Air Flow Calculation Method
    Watts/Unit,              !- Design Power Input Calculation Method
    500,                     !- Watts per Unit {W}
    100,                     !- Number of Units
    ,                        !- Watts per Zone Floor Area {W/m2}
    Data Center Operation Schedule,  !- Design Power Input Schedule Name

And then I saw this and think this branch fixed something:

Schedule:Constant,Data Center Operation Schedule,Any Number,1.0;

These 8 days types show diffs:

Minimum Equipment Level for Weekdays {W}, Maximum Equipment Level for Weekdays {W},Minimum Equipment Level for Weekends/Holidays {W}, Maximum Equipment Level for Weekends /Holidays {W},Minimum Equipment Level for Summer Design Days {W}, Maximum Equipment Level for Summer Design Days {W},Minimum Equipment Level for Winter Design Days {W}, Maximum Equipment Level for Winter Design Days {W}

 ! <ElectricEquipment:ITE:AirCooled Internal Gains Nominal>,Name,Schedule Name,Zone Name,Zone Floor Area {m2},# Zone Occupants,Equipment Level {W},Equipment/Floor Area {W/m2},Equipment per person {W/person},Fraction Convected,CPU End-Use SubCategory,Fan End-Use SubCategory,UPS End-Use SubCategory,Minimum Equipment Level for All Day Types {W},Maximum Equipment Level for All Day Types {W},Minimum Equipment Level for Weekdays {W}, Maximum Equipment Level for Weekdays {W},Minimum Equipment Level for Weekends/Holidays {W}, Maximum Equipment Level for Weekends /Holidays {W},Minimum Equipment Level for Summer Design Days {W}, Maximum Equipment Level for Summer Design Days {W},Minimum Equipment Level for Winter Design Days {W}, Maximum Equipment Level for Winter Design Days {W},Design Air Volume Flow Rate {m3/s}
- ElectricEquipment:ITE:AirCooled Internal Gains Nominal, DATA CENTER SERVERS,DATA CENTER OPERATION SCHEDULE,MAIN ZONE,232.26,0.0,50000.000,215.278,N/A,1.0,ITE-CPU,ITE-Fans,ITE-UPS,5000.000,50000.000,0.000,0.000,0.000,0.000,0.000,0.000,0.000,0.000,5.0000000000
+ ElectricEquipment:ITE:AirCooled Internal Gains Nominal, DATA CENTER SERVERS,DATA CENTER OPERATION SCHEDULE,MAIN ZONE,232.26,0.0,50000.000,215.278,N/A,1.0,ITE-CPU,ITE-Fans,ITE-UPS,5000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,50000.000,5.0000000000

This is a bug in develop. The day schedule MaxTSVal and MinTSVal were not set before this report was printed so they show up as zeros.

github-actions · 2024-12-20T01:25:44Z

⚠️ Regressions detected on macos-14 for commit `965996f`

Regression Summary

EIO: 63
EDD: 32
Table Big Diffs: 11
Table String Diffs: 309
ERR: 49
Table Small Diffs: 45
ESO Small Diffs: 39
MTR Small Diffs: 28
ESO Big Diffs: 4
SSZ Small Diffs: 1
ZSZ Big Diffs: 1

rraustad · 2024-12-20T03:50:40Z

src/EnergyPlus/Pumps.cc

@@ -892,10 +887,9 @@ void GetPumpInput(EnergyPlusData &state)

        // Input the optional schedule for the pump
        if (thisInput->cAlphaArgs(6).empty()) { // Initialized to zero, don't get a schedule for an empty
-            thisPump.flowRateSched = Sched::GetScheduleAlwaysOn(state);
+            thisPump.flowRateSched = nullptr;


It's already null

Sched::Schedule *flowRateSched = nullptr; // Flow rate modifier schedule, blank/missing --> AlwaysOn

github-actions · 2024-12-20T16:11:08Z

⚠️ Regressions detected on macos-14 for commit `18b9d6b`

Regression Summary

EIO: 69
EDD: 34
Table Big Diffs: 10
Table String Diffs: 327
ERR: 53
Table Small Diffs: 51
ESO Small Diffs: 38
MTR Small Diffs: 31
ESO Big Diffs: 4
PERF_LOG: 1

rraustad · 2024-12-20T21:12:16Z

src/EnergyPlus/Pumps.cc

-        RotSpeed_Min = thisPump.VFD.minRPMSched->getCurrentVal();
-        RotSpeed_Max = thisPump.VFD.maxRPMSched->getCurrentVal();
+        RotSpeed_Min = thisPump.VFD.minRPMSched ? thisPump.VFD.minRPMSched->getCurrentVal() : 0.0;
+        RotSpeed_Max = thisPump.VFD.maxRPMSched ? thisPump.VFD.maxRPMSched->getCurrentVal() : 0.0;


I'm surprised this would crash. If HasVFD = true then min/maxRPMSched must be valid schedules.

github-actions · 2024-12-21T00:36:32Z

⚠️ Regressions detected on macos-14 for commit `4837cb4`

Regression Summary

EIO: 66
EDD: 34
Table Big Diffs: 7
Table String Diffs: 327
ERR: 53
Table Small Diffs: 51
ESO Small Diffs: 38
MTR Small Diffs: 31
ESO Big Diffs: 1
PERF_LOG: 1

github-actions · 2024-12-23T20:46:04Z

⚠️ Regressions detected on macos-14 for commit `076b6e7`

Regression Summary

EIO: 66
EDD: 34
Table Big Diffs: 7
Table String Diffs: 321
ERR: 53
Table Small Diffs: 51
ESO Small Diffs: 38
MTR Small Diffs: 31
ESO Big Diffs: 1
PERF_LOG: 1

rraustad · 2024-12-23T20:57:21Z

src/EnergyPlus/RefrigeratedCase.cc

@@ -2242,7 +2242,7 @@ void GetRefrigerationInput(EnergyPlusData &state)
            }

            ++AlphaNum; // A6
-            if (lAlphaBlanks(AlphaNum)) {
+            if (!lAlphaBlanks(AlphaNum)) {


What's this?

I was trying to bisect something I was seeing locally so I reverted this line. I didn't work.

github-actions · 2024-12-23T21:56:41Z

⚠️ Regressions detected on macos-14 for commit `9876a00`

Regression Summary

EIO: 65
EDD: 34
Table Big Diffs: 6
Table String Diffs: 327
ERR: 52
Table Small Diffs: 51
ESO Small Diffs: 38
MTR Small Diffs: 30
ESO Big Diffs: 1
PERF_LOG: 1

amirroth added 2 commits December 5, 2024 14:50

Initial commit, pre develop merge.

2d1b4c3

Merge develop, resolve conflicts

6a339a8

amirroth added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Dec 6, 2024

amirroth added this to the EnergyPlus 25.1 milestone Dec 6, 2024

amirroth self-assigned this Dec 6, 2024

rraustad reviewed Dec 6, 2024

View reviewed changes

First round of fixes

d0b7ff9

Fix EMS issues and several others

1272641

amirroth added 3 commits December 9, 2024 10:09

Fix a few more issues

0a5be5d

Doh, forgot to update some unit test files

ed1b393

One more

aa645ef

Fix some audit, rdd, and eio diffs

b8b9473

Fix accumulation/averaging issue

72066d1

Changing to std::vector for debugging purposes

5f69976

Spell out std::find, std::fill, and std::accumulate so that we can us…

60706a3

…e vectors and not just arrays

Moving a few more std::find's to loops

1c1ead8

I'm officially starting to lose it

7b4e5a4

Fix a few more memory issues and crashes

98978bd

amirroth added 2 commits December 16, 2024 11:03

Fix EMS issue

aa03507

VRF fix

04e1872

JasonGlazer mentioned this pull request Dec 16, 2024

Report System Summary:Thermostat Schedules depends on order of ZoneControl:Thermostat control types #10857

Open

3 tasks

amirroth added 2 commits December 17, 2024 20:39

More fixes from RRaustad

4f8a09e

ZoneContaminant and format fixes

0fe2ff0

More fixes, or maybe just changes

33b94a9

One step back

dfc8545

rraustad reviewed Dec 20, 2024

View reviewed changes

Address nullptr-based failures

13c52af

rraustad reviewed Dec 20, 2024

View reviewed changes

Fix more crashes and diffs

4243a37

amirroth added 3 commits December 21, 2024 11:14

Merge remote-tracking branch 'origin/develop' into ScheduleAPI

278e872

WalkIn freezer fix

c6833bb

A few cases that didn't pass visual code inspection

d26c66d

rraustad reviewed Dec 23, 2024

View reviewed changes

Got a little too exuberant

7d637f2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Schedule API #10848

Schedule API #10848

amirroth commented Dec 6, 2024 •

edited by rraustad

Loading

github-actions bot commented Dec 6, 2024

rraustad Dec 6, 2024

rraustad commented Dec 6, 2024 •

edited

Loading

amirroth commented Dec 6, 2024

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 8, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 12, 2024

rraustad commented Dec 14, 2024 •

edited

Loading

rraustad commented Dec 14, 2024 •

edited

Loading

amirroth commented Dec 15, 2024

amirroth commented Dec 15, 2024

github-actions bot commented Dec 16, 2024

github-actions bot commented Dec 18, 2024

github-actions bot commented Dec 19, 2024

rraustad commented Dec 19, 2024 •

edited

Loading

amirroth commented Dec 19, 2024

github-actions bot commented Dec 20, 2024

rraustad Dec 20, 2024

github-actions bot commented Dec 20, 2024

rraustad Dec 20, 2024

github-actions bot commented Dec 21, 2024

github-actions bot commented Dec 23, 2024

rraustad Dec 23, 2024

amirroth Dec 23, 2024

github-actions bot commented Dec 23, 2024

Schedule API #10848

Are you sure you want to change the base?

Schedule API #10848

Conversation

amirroth commented Dec 6, 2024 • edited by rraustad Loading

Pull request overview

github-actions bot commented Dec 6, 2024

⚠️ Regressions detected on macos-14 for commit 4d72d8a

rraustad Dec 6, 2024

Choose a reason for hiding this comment

rraustad commented Dec 6, 2024 • edited Loading

amirroth commented Dec 6, 2024

github-actions bot commented Dec 7, 2024

⚠️ Regressions detected on macos-14 for commit b8e50a6

github-actions bot commented Dec 8, 2024

⚠️ Regressions detected on macos-14 for commit 19a54ba

github-actions bot commented Dec 9, 2024

⚠️ Regressions detected on macos-14 for commit 2f6289a

github-actions bot commented Dec 9, 2024

⚠️ Regressions detected on macos-14 for commit faf2d8b

github-actions bot commented Dec 10, 2024

⚠️ Regressions detected on macos-14 for commit 2d9f415

github-actions bot commented Dec 11, 2024

⚠️ Regressions detected on macos-14 for commit f2c5bbe

github-actions bot commented Dec 11, 2024

⚠️ Regressions detected on macos-14 for commit 27cf685

github-actions bot commented Dec 11, 2024

⚠️ Regressions detected on macos-14 for commit 07edd4f

github-actions bot commented Dec 12, 2024

⚠️ Regressions detected on macos-14 for commit e0d5bc5

rraustad commented Dec 14, 2024 • edited Loading

rraustad commented Dec 14, 2024 • edited Loading

amirroth commented Dec 15, 2024

amirroth commented Dec 15, 2024

github-actions bot commented Dec 16, 2024

⚠️ Regressions detected on macos-14 for commit 483072d

github-actions bot commented Dec 18, 2024

⚠️ Regressions detected on macos-14 for commit c376533

github-actions bot commented Dec 19, 2024

⚠️ Regressions detected on macos-14 for commit aa49c0d

rraustad commented Dec 19, 2024 • edited Loading

amirroth commented Dec 19, 2024

github-actions bot commented Dec 20, 2024

⚠️ Regressions detected on macos-14 for commit 965996f

rraustad Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 20, 2024

⚠️ Regressions detected on macos-14 for commit 18b9d6b

rraustad Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 21, 2024

⚠️ Regressions detected on macos-14 for commit 4837cb4

github-actions bot commented Dec 23, 2024

⚠️ Regressions detected on macos-14 for commit 076b6e7

rraustad Dec 23, 2024

Choose a reason for hiding this comment

amirroth Dec 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 23, 2024

⚠️ Regressions detected on macos-14 for commit 9876a00

amirroth commented Dec 6, 2024 •

edited by rraustad

Loading

⚠️ Regressions detected on macos-14 for commit `4d72d8a`

rraustad commented Dec 6, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `b8e50a6`

⚠️ Regressions detected on macos-14 for commit `19a54ba`

⚠️ Regressions detected on macos-14 for commit `2f6289a`

⚠️ Regressions detected on macos-14 for commit `faf2d8b`

⚠️ Regressions detected on macos-14 for commit `2d9f415`

⚠️ Regressions detected on macos-14 for commit `f2c5bbe`

⚠️ Regressions detected on macos-14 for commit `27cf685`

⚠️ Regressions detected on macos-14 for commit `07edd4f`

⚠️ Regressions detected on macos-14 for commit `e0d5bc5`

rraustad commented Dec 14, 2024 •

edited

Loading

rraustad commented Dec 14, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `483072d`

⚠️ Regressions detected on macos-14 for commit `c376533`

⚠️ Regressions detected on macos-14 for commit `aa49c0d`

rraustad commented Dec 19, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `965996f`

⚠️ Regressions detected on macos-14 for commit `18b9d6b`

⚠️ Regressions detected on macos-14 for commit `4837cb4`

⚠️ Regressions detected on macos-14 for commit `076b6e7`

⚠️ Regressions detected on macos-14 for commit `9876a00`