Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidAPI Continued #10872

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

FluidAPI Continued #10872

wants to merge 4 commits into from

Conversation

amirroth
Copy link
Collaborator

@amirroth amirroth commented Dec 22, 2024

This is a continuation of this PR which created an object-oriented API for FluidProperties. This PR propagates this API to Water and Steam uses outside of plant. The next PR will propagate the API to plant.

There are no diffs as expected, this is just a "simple" search-and-replace PR. If I knew Python as well as @Myoldmopar, I probably could have done this using an actual search-and-replace.

@amirroth amirroth assigned amirroth and Myoldmopar and unassigned amirroth Dec 23, 2024
@amirroth amirroth added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring DoNotPublish Includes changes that shouldn't be reported in the changelog labels Dec 23, 2024
@amirroth amirroth added this to the EnergyPlus 25.1 milestone Dec 23, 2024
@rraustad
Copy link
Contributor

Local results:
image

@amirroth
Copy link
Collaborator Author

amirroth commented Dec 24, 2024

Local results: image

Why did this not show up in my inbox? Also, this doesn't jibe with the successful test report below. Is this stale maybe?

@rraustad
Copy link
Contributor

5ZoneAirCooledConvCoef_VSFan shows this error for develop and this branch (this type of error should not be a fatal):

** Severe  ** Iteration limit exceeded in calculating variable speed fan powered box 1st stage heating fan speed
**   ~~~   **  Environment=RUN PERIOD 1, at Simulation time=09/30 06:27 - 06:30
**  Fatal  ** PIU control failed for AirTerminal:SingleDuct:ParallelPIU:Reheat:SPACE4-1 VAV REHEAT 

AbsorptionChiller_Macro failed to run, for some reason, in develop and this branch (a regression tool issue?).
ShopWithPVandLiIonBattery failed in this branch with a sqlite error:

SQLite3 message, sqlite.err open for processing!

So I don't think these failures are related to changes in this branch. I'm not sure why the VSFan file runs on Linux, or if it even did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants