-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the NIST Life Cycle Cost Escalations for 2023 and 2024 #10881
Conversation
…and small script mods
@@ -137,12 +137,12 @@ def parse_encost(fpath: Path) -> Tuple[List[dict], int]: | |||
continue | |||
|
|||
if region is None: | |||
region = line | |||
region = line.expandtabs(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify why this is needed? what is line
when you reach here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The encost file is not separate anymore and is part of a spreadsheet. For 2023 it is an ODS, and for 2024, it is an xlsx file. Both were using tabs instead of the space delimited format of previous years when the encost.txt file was available separately.
# print(f"{region=}") | ||
continue | ||
|
||
if years is None: | ||
years = [int(x) for x in line.split(" ")] | ||
years = [int(x) for x in line.split()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question really. What other types of whitespaces other than " "
do you have? tabs again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes were just because I was running on a Windows machine and had the files in a different place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as is. @JasonGlazer is generally the only one who runs the Python update file, so I won't worry about the tweaks to that file. I appreciate that you at least provided the Python file so we could use it if we needed in the future, even with our own tweaks. This is going in.
Pull request overview
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.