Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Reduce Example Runtimes #266

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

RHammond2
Copy link
Collaborator

This PR is based on #264 and does two things:

  • Reduces the number of simulations performed in
    • 02c_augmented_plant_aep_analysis.ipynb
    • 03_turbine_ideal_energy.ipynb
    • 05_eya_gap_analysis.ipynb

As was discussed in a meeting, Jupyter warnings and notes look awkward, so this will also address the formatting issues by adopting the MyST plugin for Jupyter Lab. The addition enables admonitions to look like they would in the documentation itself, which relies on MyST.

This will move out of a draft PR once #265 is merged in, so the formatting can be updated there as well.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfc49cd) 75.31% compared to head (e2fca44) 77.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
+ Coverage    75.31%   77.14%   +1.82%     
===========================================
  Files           29       29              
  Lines         3760     3671      -89     
===========================================
  Hits          2832     2832              
+ Misses         928      839      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RHammond2 RHammond2 merged commit bfea0b8 into NREL:develop Feb 12, 2024
6 checks passed
@RHammond2 RHammond2 deleted the enhancement/notebook-runtime branch February 12, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some cells in the example notebooks take a long time to run.
3 participants