-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Reduce Example Runtimes #266
Merged
RHammond2
merged 6 commits into
NREL:develop
from
RHammond2:enhancement/notebook-runtime
Feb 12, 2024
Merged
Enhancement: Reduce Example Runtimes #266
RHammond2
merged 6 commits into
NREL:develop
from
RHammond2:enhancement/notebook-runtime
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #266 +/- ##
===========================================
+ Coverage 75.31% 77.14% +1.82%
===========================================
Files 29 29
Lines 3760 3671 -89
===========================================
Hits 2832 2832
+ Misses 928 839 -89 ☔ View full report in Codecov by Sentry. |
2 tasks
ejsimley
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #264 and does two things:
02c_augmented_plant_aep_analysis.ipynb
03_turbine_ideal_energy.ipynb
05_eya_gap_analysis.ipynb
As was discussed in a meeting, Jupyter warnings and notes look awkward, so this will also address the formatting issues by adopting the MyST plugin for Jupyter Lab. The addition enables admonitions to look like they would in the documentation itself, which relies on MyST.
This will move out of a draft PR once #265 is merged in, so the formatting can be updated there as well.