Fix #5314 - Add Tank Element Control Logic field to WaterHeaterHeatPump

[jmarrec]

Pull request overview

• Fix WaterHeater:HeatPump Field !- Tank Element Control Logic is not exposed #5314
• Add Tank Element Control Logic field to WaterHeaterHeatPump

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

clang-format is tripping.

diff --git a/src/gltf/GltfMaterialData.hpp b/src/gltf/GltfMaterialData.hpp
index 531ad5aea7..675ad6783c 100644
--- a/src/gltf/GltfMaterialData.hpp
+++ b/src/gltf/GltfMaterialData.hpp
@@ -36,7 +36,7 @@ namespace gltf {
 
     /** Standard constructor */
     constexpr GltfMaterialData(std::string_view materialName, int r, int g, int b, double a, bool isDoubleSided = false)
-      : m_materialName(materialName), m_r(r), m_g(g), m_b(b), m_a(a), m_isDoubleSided(isDoubleSided) {};
+      : m_materialName(materialName), m_r(r), m_g(g), m_b(b), m_a(a), m_isDoubleSided(isDoubleSided){};
 
     static std::vector<GltfMaterialData> buildMaterials(const model::Model& model);
     //@}

OpenStudio/src/gltf/GltfMaterialData.hpp

Line 39 in b01d323

: m_materialName(materialName), m_r(r), m_g(g), m_b(b), m_a(a), m_isDoubleSided(isDoubleSided){};

[jmarrec]

And once again, we get an issue where an older VT test is now failing due to new VT rules... pfff. At some point we really should fix it by stopping VT at the target version

[ci-commercialbuildings]

CI Results for 2e37401:

• Ubuntu 24.04:

  • OpenStudio-3.9.1-alpha+2e37401ff9-Ubuntu-24.04-x86_64.deb
  • OpenStudio-3.9.1-alpha+2e37401ff9-Ubuntu-24.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.9.1-alpha+2e37401ff9-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.9.1-alpha+2e37401ff9-Ubuntu-22.04-x86_64.tar.gz
  • perf_test/results.html

• Darwin:

  • OpenStudio-3.9.1-alpha+2e37401ff9-Darwin-x86_64.dmg
  • OpenStudio-3.9.1-alpha+2e37401ff9-Darwin-x86_64.tar.gz

• Windows:

• Code Coverage:

[jmarrec]

K, tests are clean on the ubuntus, and this is simple enough. I'm going to merge it, because we're piling PRs, and especially PRs with IDD changes, and with CI that's unreliable it's annoying