Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5189 - Register AFN scheduleTypeRegistry. #5334

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix #5189 - Register AFN scheduleTypeRegistry. #5334

wants to merge 1 commit into from
+14 −9

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Dec 19, 2024

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Airflow Network labels Dec 19, 2024
@jmarrec jmarrec requested a review from shorowit December 19, 2024 15:43
@jmarrec jmarrec self-assigned this Dec 19, 2024
jmarrec
jmarrec commented Dec 19, 2024
View reviewed changes
src/model/ScheduleTypeRegistry.cpp
Comment on lines +97 to +98
{"AirflowNetworkOccupantVentilationControl", "Opening Probability", "openingProbabilitySchedule", true, "", 0.0, 1.0},
{"AirflowNetworkOccupantVentilationControl", "Closing Probability", "closingProbabilitySchedule", true, "", 0.0, 1.0},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for opening/closing prob, it's expected in [0, 1]

cf https://github.com/NREL/EnergyPlus/blob/acda84e38db4e8aecbc178cb970055d3721ee321/src/EnergyPlus/AirflowNetwork/src/Solver.cpp#L12908-L12914

src/model/ScheduleTypeRegistry.cpp
Comment on lines +99 to +104
{"AirflowNetworkSurface", "Ventilation Control Zone Temperature Setpoint", "ventilationControlZoneTemperatureSetpointSchedule", true,
"Temperature", OptionalDouble(), OptionalDouble()},
{"AirflowNetworkSurface", "Venting Availability", "ventingAvailabilitySchedule", false, "Availability", 0.0, 1.0},
{"AirflowNetworkZone", "Ventilation Control Zone Temperature Setpoint", "ventilationControlZoneTemperatureSetpointSchedule", true,
"Temperature", OptionalDouble(), OptionalDouble()},
{"AirflowNetworkZone", "Venting Availability", "ventingAvailabilitySchedule", false, "Availability", 0.0, 1.0},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest

@jmarrec jmarrec force-pushed the 5189-AFNScheduleTypeRegistry branch from cc3c9e8 to 7313467 Compare December 23, 2024 16:31
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Dec 23, 2024 •
edited
Loading

CI Results for 7313467:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit Awaiting requested review from shorowit

Assignees

@jmarrec jmarrec

Labels
component - Airflow Network Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AFN venting schedule not registered for class AirflowNetworkZone
2 participants
@jmarrec @ci-commercialbuildings