Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext data export, Variable defaults, and Data File Scenario Filtering #38

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

ktehranchi
Copy link
Collaborator

  • Ensures ext data can be exported by cleansing it of data which cannot be serialized
  • Adds variable default property value for cases when variables do not point to a data file
  • Adds a separate datafile query in get_model_data to perform filtering of datafiles where one data_file_tag can specify multiple scenarios of datafiles. This is attached to this PR in plexosdb Adds datafile text field for Data File object query plexosdb#15

NOTE: The current implementation for variable and data_file querying is due for a refactor and cleanse... I will make a GitHub issue to specify my thoughts on the best path forward. The current implementation works, with one funky artifact- fields which have datafile scenarios specified, will have their properties duplicated in the output of get_model_data. This impacts very few fields since most scenarios are applied to variables instead of datafiles.

No impact on results but I throw a warning when duplicate fields replace each others data, but its all correct data replacing other correct data.

@ktehranchi ktehranchi requested a review from pesap September 17, 2024 04:01
src/r2x/api.py Show resolved Hide resolved
src/r2x/exporter/sienna.py Outdated Show resolved Hide resolved
src/r2x/parser/plexos.py Show resolved Hide resolved
src/r2x/parser/plexos.py Show resolved Hide resolved
@ktehranchi ktehranchi requested a review from pesap September 18, 2024 00:09
@pesap pesap merged commit e963011 into main Sep 18, 2024
7 checks passed
@pesap pesap deleted the kt/ext branch September 18, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants