Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC coupled PV and ElectricStorage #476

Draft
wants to merge 120 commits into
base: develop
Choose a base branch
from
Draft

DC coupled PV and ElectricStorage #476

wants to merge 120 commits into from

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Feb 5, 2025

No description provided.

hdunham added 30 commits January 14, 2025 11:18
@hdunham
set up testing
3931a81
@hdunham
add results to compare to
41af908
@hdunham
Update debugging_tests.jl
f6afbd0
@hdunham
add dc_coupled_with_battery option to PV model
94192fe
@hdunham
rename result file
001a6ee
@hdunham
update testing
9e8f5e4
@hdunham
warn that PV inv_eff ignored if dc_coupled_with_electric_storage
f79e4a6
@hdunham
create dc and ac coupled tech sets
584bc3f
@hdunham
store dc_(dis)charge_efficiency in ElectricStorage
1d655ce
@hdunham
test checkpoint
195bd5e
@hdunham
return dc prod if dc_coupled_with_battery in call_pvwatts_api
1be7e8c
@hdunham
correct call_pvwatts_api arg issues
8b4ad0b
@hdunham
REVERT LATER temp return ac prod for dc coupled
5bdd53d
@hdunham
create dvDCCoupledTechStorageInverterSize
a741853
@hdunham
create DV for dc coupled inverter size
caa574c
@hdunham
add dc_couple_inverter_size_kw to ElectricStorage results
8ee32a6
@hdunham
rename to dc_coupled_with_storage
42b00b3
@hdunham
make dc coupled constraints compatible with multinode
28f36a7
@hdunham
call dc coupled constraints if dc coupled tech not not empty
a61629e
@hdunham
update consrtaint on dvDCCoupledTechStorageInverterSize
ee0e7d0
@hdunham
don't let AC coupled techs charge dc coupled bess
a5072f5
@hdunham
update test scenarios
adc276d
@hdunham
update testing
7b6c0fe
@hdunham
update testing
ce59f4f
@hdunham
Revert "don't let AC coupled techs charge dc coupled bess"
78dab57 
This reverts commit a5072f5.
@hdunham
Update debugging_tests.jl
68cda37
@hdunham
testing checkpoint
266f472
@hdunham
Reapply "don't let AC coupled techs charge dc coupled bess"
3f25088 
This reverts commit 78dab57.
@hdunham
update testing
878f864 
was subtracting prod from load wrong; shortened outage
@hdunham
Revert "don't let AC coupled techs charge dc coupled bess"
5eab825 
This reverts commit a5072f5.
hdunham added 30 commits February 11, 2025 14:22
@hdunham
add dc_coupled input to dc test posts
231547c
@hdunham
apply efficiencies in stor power constraints
0885aa8
@hdunham
test (size_kw, size_kwh, pv, lcc all up)
0bac613
@hdunham
use dc_coupled stor set to call add_dc_coupled_tech_elec_storage_cons…
9601ec4 
…traints
@hdunham
add DC to DV name to clarify
0cbe847 
dvDCCoupledTechStorageInverterSizeDC
@hdunham
apply inv and rect effic in dvDCCoupledTechStorageInverterSizeDC cons…
6f9c860 
…traints
@hdunham
apply inv and rect effic in outages dvDCCoupledTechStorageInverterSiz…
059a087 
…eDC constraints
@hdunham
merge DC coupled inverter constraints charge/discharge directions
defa5cd 
and replace b with "ElectricStorage" to fix error in outage version
@hdunham
test (no change)
4ef6429 
b/c dc coupled inv size was already constrained to 104kw from PV to load and inv effic
@hdunham
check p.s.storage.types.dc_coupled empty not p.techs.dc_couple_with_stor
24ddaa3
@hdunham
add ac_coupled storage set
b9e557c
@hdunham
always use !isempty(p.s.storage.types.dc_coupled) as condition
2483373 
for dvDCCoupledTechStorageInverterSizeDC
@hdunham
update storage cap cost objective term
45e1f0b 
to cost total dc coupled inverter size not just battery power when dc coupled
@hdunham
update big M calc in outage_constraints
618d21e 
to account for total dc coupled system costed at storage kw cost
@hdunham
dvDCCoupledTechStorageInverterSizeDC >= dvStoragePower
57932b1
@hdunham
test no changes
032527a
@hdunham
rm debuging infos
0108a99
@hdunham
rm commented old line
a3d774b
@hdunham
index dvDCCoupledTechStorageInverterSizeDC on only dc coupled stors
ccca421
@hdunham
update check before getting result
940a86b 
of dvDCCoupledTechStorageInverterSizeDC
@hdunham
test no changes
3cd3ea1
@hdunham
rename dc_couple_with_stor to dc_coupled_with_storage
4ee31a7
@hdunham
formatting
338a640
@hdunham
Don’t allow existing PV that is DC coupled
7312563 
b/c no option for existing batt
@hdunham
Enforce storage dc coupled input to be true if PV one is
30eccac
@hdunham
add missed end
b7b4976
@hdunham
test no changes
500bf01
@hdunham
test error if PV dc coupled but not stor
7112d00
@hdunham
Revert "test error if PV dc coupled but not stor"
87914c7 
This reverts commit 7112d00.
@hdunham
error if stor dc coupled but pv not
eeed005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hdunham