Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown #394

Merged
merged 36 commits into from
Dec 13, 2024
Merged

Shutdown #394

merged 36 commits into from
Dec 13, 2024

Conversation

abhineet-gupta
Copy link
Collaborator

@abhineet-gupta abhineet-gupta commented Nov 15, 2024 •
edited
Loading

Description and Purpose

Add more shutdown triggers to ROSCO.

Type of change

What types of change is it?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

Add example 30_shutdown

@abhineet-gupta abhineet-gupta marked this pull request as draft November 15, 2024 16:44
@abhineet-gupta
Copy link
Collaborator Author

Not sure why tests are failing. test_examples.py runs successfully both on macos and linux.

@abhineet-gupta
Copy link
Collaborator Author

Question:
Running update_rosco_discons.py modifies all the DISCON.IN files in Test_Cases as expected but also changes VS_Rgn2K. Is this expected?
Note that the same happens on the dev branch and update_rosco_discons.py gets executed during regression testing here.

@abhineet-gupta abhineet-gupta marked this pull request as ready for review December 4, 2024 16:58
dzalkind and others added 14 commits December 4, 2024 10:02
@dzalkind
Copy link
Collaborator

Thanks @abhineet-gupta for your contribution here! I think this will help in our DLC analysis and provides a good structure for future methods as well.

I'll merge this once it passes the tests. A merge conflict broke one of the tests.

@dzalkind dzalkind merged commit 938e4f1 into develop Dec 13, 2024
52 of 53 checks passed
@dzalkind dzalkind deleted the shutdown branch December 13, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzalkind dzalkind dzalkind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhineet-gupta @dzalkind