Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addresses SAM issue 1455 #1498

Merged
merged 18 commits into from
Oct 17, 2023
Merged

addresses SAM issue 1455 #1498

merged 18 commits into from
Oct 17, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Oct 13, 2023

Goes with NREL/wex#165

Sort order for technology tree specified in startup.lk as (note that not all technologies have to be specified):
image

Which results in configuration window display as:
image

If no "TechnologyTreeOrder" configopt specified in startup.lk, the result is how items appear in startup.lk:
image

The financial tree and page order sorting has not yet been implemented.

Will proceed based on this pull request feedback

@sjanzou sjanzou self-assigned this Oct 13, 2023
@sjanzou sjanzou linked an issue Oct 13, 2023 that may be closed by this pull request
@mjprilliman
Copy link
Collaborator

Is there a way to clear the input page selection from the tree when the Results button next to Simulate is pressed? If you do steps:

  1. Click Simulate
  2. From Results page click an input page to return to inputs.
  3. Click Results button to right of Simulate to return to Results
  4. Click on still highlighted input page in tree.

Nothing happens. The easy workaround is to select a different input page. There is also the question of the Results button being disabled, which has it's own issue #1485

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Tree sorting works as advertised in Linux (Mint 21.1).

With sorting in startup:

tech-tree-sorted

Without sorting, Hybrid is at bottom:

tech-tree-not-sorted

Note that in Linux, selected technology is white (invisible) when financing is selected (not a high priority to fix):

tech-tree-invisible-tech

@sjanzou
Copy link
Collaborator Author

sjanzou commented Oct 15, 2023

Is there a way to clear the input page selection from the tree when the Results button next to Simulate is pressed? If you do steps:

  1. Click Simulate
  2. From Results page click an input page to return to inputs.
  3. Click Results button to right of Simulate to return to Results
  4. Click on still highlighted input page in tree.

Nothing happens. The easy workaround is to select a different input page. There is also the question of the Results button being disabled, which has it's own issue #1485

Updated with latest commit - please retest.

@sjanzou
Copy link
Collaborator Author

sjanzou commented Oct 17, 2023

tested RHEL 8.6, MacOS 14.0 and Windows 11

image

@sjanzou sjanzou merged commit ed0b465 into develop Oct 17, 2023
2 of 4 checks passed
@sjanzou sjanzou deleted the SAM_1455 branch October 17, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS Navigation tree issues
3 participants