Fix/drag coeff func #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calbaker
reviewed
Sep 18, 2024
python/altrios/train_planner.py
Outdated
|
|
||
| """ | ||
|
|
||
| ## From slide 16 of the Aerodynamic model PPT |
There was a problem hiding this comment.
@sakhtar312 , if possible let's change this to a publicly referenceable source
calbaker
reviewed
Sep 18, 2024
python/altrios/train_planner.py
Outdated
| Arguments: | ||
| --------- | ||
| num_rail_vehicles: int - Number of rail vehicles in the platoon | ||
| ps_gap_size: float - Gap size between the rail vehicles |
There was a problem hiding this comment.
@sakhtar312 , make this more generic!
There was a problem hiding this comment.
@sakhtar312 , do you recall where we left off with this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening up a pull request to integrate the changes in
train_planner.py. Main summary of the changes are as follows:TrainPlannerConfigclass. Necessary changes are made inrun_train_planner.pyto accommodate the change and the new implementation has been tested.rail_vehiclestructure.sim_manager_demo.pyruns with the new 'rail_vehicle' structure.