Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up turbine loading operation #966

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Speed up turbine loading operation #966

merged 7 commits into from
Aug 26, 2024

Commits on Aug 20, 2024

  1. Instantiate Turbine objects only once for each different type of turb… 

    …ine.
    @misi9170
    misi9170 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7a1a0d3 View commit details
    Browse the repository at this point in the history

  2. Raise clear error of turbine_type is same but dictionaries do not match

    @misi9170
    misi9170 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    cb2f1c4 View commit details
    Browse the repository at this point in the history

  3. Clean up comments.

    @misi9170
    misi9170 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8c18d54 View commit details
    Browse the repository at this point in the history

  4. Add test to check that turbine_definitions and turbine_map reflect ch… 

    …anges as expected.
    @misi9170
    misi9170 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    044ab0b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Use private attribute _turbine_definition_cache throughout.

    @misi9170
    misi9170 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b42852f View commit details
    Browse the repository at this point in the history

  2. use factory=dict on attrs attribute to avoid need to assign empty {}

    @misi9170
    misi9170 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3501754 View commit details
    Browse the repository at this point in the history

  3. Add factory=list to _turbine_types private attribute to ensure acts a… 

    …s expected.
    @misi9170
    misi9170 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    575ff0b View commit details
    Browse the repository at this point in the history