Feat/cache queries #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - Function to create an integer for query_string/param input - _QUERY_CACHE object to hold results from all queries
Some queries do change throught the process of using plexosdb from r2x, get_id should not change during a run
- Added flag to turn cache on/off - Added clear_id_cache method - Moved all cache methods to bottom of class
JensZack
force-pushed
the
feat/cache-queries
branch
from
8bff187 to
c805239
Compare
- Enforce unique name/class for all objects - Enforce unqiue object ids for all objects - Raise ValueError if an object is added without a unique name/class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage ? 97.14%
=======================================
Files ? 5
Lines ? 596
Branches ? 0
=======================================
Hits ? 579
Misses ? 17
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
I would like to clean up the cacheing mechanism to only use class/object name, for id queries in the object table. This also raises questions about what uniqueness can be enforced in other tables where _get_id is used repeatedly. |
pesap
requested changes
Nov 21, 2024
pesap
reviewed
Nov 21, 2024
pesap
requested changes
Nov 21, 2024
pesap
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache results from _get_id
In the run of:
r2x -i temp_data/oct1024_Con_NG --input-model=reeds-US --output-model=plexos --weather-year=2012 -o .out/$CASETS --year 2035 --plugins pcm_defaults emission_cap break_gens imports --debug --upgrade --flags daily-budgets=trueIn this case:
_get_id is called 434408 times
there are only 5397 unique calls of _get_id
Caching _get_id results leads to the performance gains:
plexos_exporter: 47.3s -> 19.7s
_get_id cumulative: 28.8s -> 1.7s