Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panels TEA Run - DO NOT MERGE #1208

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

yingli-NREL
Copy link

Pull Request Description

yml review

@yingli-NREL yingli-NREL requested a review from lixiliu February 12, 2024 22:28
@lixiliu lixiliu changed the title Schedule based appliance from develop Panels TEA Run - DO NOT MERGE Feb 12, 2024
elec_folder: data/cambium/2022/LRMER_MidCase_15

utility_bills:
- scenario_name: Bills
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need additional input here for updated bill calc? I imagine we'd want the latest state avg rates, at least 2023 level.
https://github.com/NREL/resstock/tree/schedule_based_appliance_from_develop/resources/data/simple_rates

emissions:
- scenario_name: LRMER_MidCase_15
type: CO2e
elec_folder: data/cambium/2022/LRMER_MidCase_15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the one that RESNET prefers... I think it's the Low RE case with a specific levelization period, could you check with Phil and Elaina on that?

#### 1.2 Federal Minimum Heat Pump With Electric Backup, 2 options ####
- &1_fed_min_ashp_ducted
option: HVAC Heating Efficiency|ASHP, SEER 15.05, 8.82 HSPF, Max Load # same as base option
apply_logic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*logic_ducted_hvac_no_ashp

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use this reference at the first time. But got an error when validate the yml file. It looks like the logic that we referred should be in a same upgrade measure
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a question for Rajendra


- &2_fed_min_mshp_ductless
option: HVAC Heating Efficiency|MSHP, SEER 14.5, 8.33 HSPF, Max Load # federal minimum is SEER 14.3, but 14.5 is lowest SEER in baseline ResStock
apply_logic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*logic_ductless_hvac_no_mshp

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, if use the reference, got an error when validate the yml file.

- HVAC Has Ducts|Yes
- HVAC Heating Type|Non-Ducted Heating
- not: HVAC Heating Type And Fuel|Electricity ASHP
costs: *costs_ashp_ducted_8-82_HSPF
Copy link
Contributor

@lixiliu lixiliu Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cost has electric backup, not the same, make sure all HP with existing backup has different HP costs than HP with electric backup

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Largeee use the same cost for HP with existing backup and HP with electric backup.
#Cost Source in largee: Custom regression by Brennan Less. Ducted heat pump project costs were regressed on nameplate tons and HSPF. Shall we reach out to Brennan for the cost of HP with different backup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think so, let's note that in the intent doc

- not: HVAC Cooling Efficiency|Shared Cooling
- HVAC Has Ducts|No
- not: HVAC Heating Type And Fuel|Electricity MSHP
costs: *costs_mshp_ductless_8-33_HSPF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different cost than MSHP with integrated electric backup

- upgrade_name: 2.7 BAU Electrification with Existing Fuel Backup with Envelope
options:
#### 1.0 Common Options For Heat Pump with existing backup, 8 options ####
- *hp_exist_bkup_heating_fuel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking you can leverage apply_package_logic to further exclude shared systems, but this is okay!

#### 1.2 Federal Minimum Heat Pump With Electric Backup, 2 options ####
- *1_fed_min_ashp_ducted
- *2_fed_min_mshp_ductless
#### 2.1 Electric Water Heating, 4 options #### ##TO DO evise it to 120V HPWH
Copy link
Contributor

@lixiliu lixiliu Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO BE UPDATED. If you are testing the run before this is updated, I'd suggest just commenting out the entire upgrade package. Same for the others containing the 120V HPWH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants