Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load flexibility yingli #1331

Open
wants to merge 8 commits into
base: load_flexibility
Choose a base branch
from
Open

Load flexibility yingli #1331

wants to merge 8 commits into from

Conversation

yingli-NREL
Copy link

@yingli-NREL yingli-NREL commented Dec 13, 2024 •
edited
Loading

Pull Request Description

  1. Revise the peak time input json files and related code in the measure, which get rid of the variable "on_peak_duration"
  2. Add setpoint clip function to to prevent excessive heating or cooling
  3. Revise the default value of the load flexibility scenario design
  4. Did a local test run, the run is successful

@yingli-NREL yingli-NREL requested a review from rajeee December 13, 2024 22:45
rajeee
rajeee reviewed Dec 16, 2024
View reviewed changes
resources/options_lookup.tsv Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes are you making on this file? Is it required?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

yingli-NREL
yingli-NREL commented Dec 24, 2024
View reviewed changes
Copy link
Author

@yingli-NREL yingli-NREL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments

measures/ResStockArgumentsPostHPXML/resources/hvac_flexibility/setpoint_modifier.rb Outdated Show resolved Hide resolved
resources/options_lookup.tsv Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

@yingli-NREL yingli-NREL self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeee rajeee rajeee left review comments

Assignees

@yingli-NREL yingli-NREL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yingli-NREL @rajeee