Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dryer lifetimes #930

Open
wants to merge 1 commit into
base: run/abctypology
Choose a base branch
from
Open

Fix missing dryer lifetimes #930

wants to merge 1 commit into from

Conversation

ejhw
Copy link
Contributor

@ejhw ejhw commented May 13, 2022

[skip ci]

Pull Request Description

[description here]

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@ejhw ejhw requested a review from munank May 13, 2022 19:19
@shorowit
Copy link
Contributor

@ejhw What happens when there are costs but no lifetimes -- does it ignore the costs? Should we (either resstock or bsb) give a warning or error when this occurs?

@joseph-robertson
Copy link
Contributor

@ejhw @munank Can this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munank munank Awaiting requested review from munank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejhw @shorowit @joseph-robertson