Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssc_module_exec_with_error per @dguittet with filtering to fix #1105 #1107

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Dec 7, 2023

Note filtering to SSC_WARNING and SSC_ERROR only. SSC_NOTICE includes several messages that are not useful on simulation results dialog for test file (PVWatts tilt = 95) :
ssc_1105.zip


compute fail(hybrid): pvwattsv8 execution error.
fail(tilt, max=90): 95

E=90,S=180,W=270
total system losses
0=false,1=true
0=shadingdb,1=average,2=maximum,3=minimum
0=false,1=true
0=false,1=true
0=false,1=true
0=false,1=true
'adjust' and 'constant' separated by _ instead of : after SAM 2022.12.21
'adjust' and 'en_timeindex' separated by _ instead of : after SAM 2022.12.21
'adjust' and 'en_periods' separated by _ instead of : after SAM 2022.12.21

Simulation Hybrid failed :Simulation time step is 60 minutes for generic_system.


With SSC_WARNING and SSC_ERROR, cmod_hybrid reports the "standard" messages to the simulation dialog (even though "Finished with notices." is somewhat misleading.:
image

The SSC_NOTICE messages should be reported on the Notices tab in SAM.

@sjanzou sjanzou self-assigned this Dec 7, 2023
@sjanzou sjanzou linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved some of the debug issues I was having earlier.

image

Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thank you!

@sjanzou sjanzou merged commit f737221 into develop Dec 8, 2023
4 checks passed
@sjanzou sjanzou deleted the ssc_1105 branch December 8, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmod_hybrid needs to propagate errors from lower level cmods
3 participants