Distribution clipping method #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checks for divide by zero error
janinefreeman
requested changes
Feb 28, 2024
shared/lib_pv_io_manager.cpp
Outdated
| p_subhourlyClippingLossFactor = cm->allocate("subhourly_clipping_loss_factor", numberOfLifetimeRecords); | ||
| //p_subhourlyClippingLossFactor = cm->allocate("subhourly_clipping_loss_factor", numberOfLifetimeRecords); | ||
|
|
||
| p_DistributionClippingLoss = cm->allocate("distribution_clipping_loss", numberOfLifetimeRecords); |
There was a problem hiding this comment.
Should this output, and the subhourly clipping loss above, be conditionally defined to only show up if these features are enabled?
There was a problem hiding this comment.
Should the total loss and percentage outputs be conditional in the outputs as well?
There was a problem hiding this comment.
We currently have bifacial electrical mismatch show up as a potential modeled loss factor that shows up in all model runs just as a data point.
There was a problem hiding this comment.
Ah. I am always in favor of outputs only showing up when they apply, but I'm sure there are a variety that have gone unnoticed.
There was a problem hiding this comment.
No worries I can make those conditional.
janinefreeman
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implement Walker clipping method that uses distribution of PV power output to calculate clipping potential
-https://www.nrel.gov/docs/fy20osti/76859.pdf
-Accessible through SDK
-Add test for feature usage
-Linke turbidity currently fixed at 1.0, todo add surrogate or lookup for turbidity value