Sam 1806 make tolerances more consistent #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to address issues with small amounts of energy interfering with self consumption metrics
sjanzou
approved these changes
Jul 17, 2024
| @@ -37,7 +37,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| #include "lib_battery_capacity.h" | |||
|
|
|||
| double low_tolerance = 0.01; | |||
| double tolerance = 0.002; | |||
| double tolerance = 0.002; // Used for capacity calcs. Please use powerflow_tolerance for units of kW | |||
|
|
|||
|
@brtietz Does this fix NREL/SAM#1806? |
|
Yes, thanks for the reminder. Just closed that issue.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently use the powerflow tolerance throughout the battery issue to mitigate issues caused by inconsistent tolerances. Results of the parametric run after changes:
See NREL/SAM#1806 for test file. See #1132 for history on powerflow tolerance.
Test changes for grid outage and resilience code were required to accommodate tighter tolerances. Reported resilience metrics have decreased due to changing tolerance from 2 W to 0.005 W.