Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssc 1256 better hybrid batteries #1258

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 6, 2024

Fixes #1256

Pairs with NREL/SAM#1958

Overwrites "gen" in the hybrids compute module with the battery's gen, since the battery gen is an inout and include the total powerflow from all components.

Calculates annual and monthly energy values after the battery runs to capture them in the values.

Updates the test to compare these energy metrics and make sure everything is included in the annual outputs.

Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Electricity net generation' now does not equal the generator annual energy values, due to efficiency losses of energy flowing through the battery. That's fine I think, then O&M production-based expense scales with net generation. Is that right?

image

gen matches what is coming out of battery compute module now.

image

@brtietz
Copy link
Collaborator Author

brtietz commented Dec 6, 2024

That's fine I think, then O&M production-based expense scales with net generation. Is that right?

Hybrid VOM is based on energy to grid, not net generation. I've set up a few test cases where the net generation is negative, do these make sense to you?
hybrid_vom_tests.zip

@mjprilliman
Copy link
Collaborator

That's fine I think, then O&M production-based expense scales with net generation. Is that right?

Hybrid VOM is based on energy to grid, not net generation. I've set up a few test cases where the net generation is negative, do these make sense to you? hybrid_vom_tests.zip

Yes that looks right.

Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but would prefer if @sjanzou can take a look as well before merging.

Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the results make more sense not - we may have to revisit the variable o and m value for the system in the future along with subcomponent incentives.

EXPECT_NEAR(battannualenergy, 1331720000., 1e6);
EXPECT_NEAR(battchargeenergy[1], 55372248, 55372248 * 0.001);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for adding the additional outputs in the test!

@sjanzou sjanzou mentioned this pull request Dec 8, 2024
@brtietz brtietz merged commit bfca1ea into develop Dec 9, 2024
8 checks passed
@brtietz brtietz deleted the ssc_1256_better_hybrid_batteries branch December 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery charge and discharge doesn't get added to gen in hybrids compute modules
4 participants