-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ssc 1256 better hybrid batteries #1258
Conversation
…etter_hybrid_batteries
…ions for length issues. Add energy metrics to tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Electricity net generation' now does not equal the generator annual energy values, due to efficiency losses of energy flowing through the battery. That's fine I think, then O&M production-based expense scales with net generation. Is that right?
gen matches what is coming out of battery compute module now.
Hybrid VOM is based on energy to grid, not net generation. I've set up a few test cases where the net generation is negative, do these make sense to you? |
Yes that looks right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but would prefer if @sjanzou can take a look as well before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the results make more sense not - we may have to revisit the variable o and m value for the system in the future along with subcomponent incentives.
EXPECT_NEAR(battannualenergy, 1331720000., 1e6); | ||
EXPECT_NEAR(battchargeenergy[1], 55372248, 55372248 * 0.001); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and thanks for adding the additional outputs in the test!
Fixes #1256
Pairs with NREL/SAM#1958
Overwrites "gen" in the hybrids compute module with the battery's gen, since the battery gen is an inout and include the total powerflow from all components.
Calculates annual and monthly energy values after the battery runs to capture them in the values.
Updates the test to compare these energy metrics and make sure everything is included in the annual outputs.