Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate utility bill variables #1276

Open
wants to merge 6 commits into
base: patch
Choose a base branch
from

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Feb 12, 2025

Fixes NREL/SAM#1879

Goes with NREL/SAM#2009, see that PR for details.

Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you had to change 47 test files!

@brtietz
Copy link
Collaborator

brtietz commented Feb 13, 2025

I know this is a nitpick given the current release plan, but variable changes like this should be merged into develop, not patch.

@brtietz
Copy link
Collaborator

brtietz commented Feb 13, 2025

I ran find and replace a few times to identify potential errors, and turned up the following:

image

(sys_system instead of just sys)

There were also a few hits in the PySAM examples:

image

What is the appropriate time to update those?

@cpaulgilman
Copy link
Collaborator Author

There were also a few hits in the PySAM examples:

This should be addressed in NREL/pysam#185

@cpaulgilman
Copy link
Collaborator Author

(sys_system instead of just sys)

Good find. Thanks! Should be fixed in 0de61b7.

I also noticed one other set of variables that use "system" instead of "sys" in this context:

year1_monthly_peak_wo_system
year1_monthly_use_wo_system
year1_monthly_peak_w_system
year1_monthly_use_w_system

@brtietz, is it worth changing that? These variables seem to only be used as outputs to utilityrate5, so changing their names should have no impact on other SSC/SAM code and samples, but will affect any SDK/PySAM code out in the world that refers to those outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annual Electricity bill with and without system duplicated for FOM and BTM systems
3 participants