-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate utility bill variables #1276
base: patch
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you had to change 47 test files!
I know this is a nitpick given the current release plan, but variable changes like this should be merged into develop, not patch. |
This should be addressed in NREL/pysam#185 |
Good find. Thanks! Should be fixed in 0de61b7. I also noticed one other set of variables that use "system" instead of "sys" in this context:
@brtietz, is it worth changing that? These variables seem to only be used as outputs to utilityrate5, so changing their names should have no impact on other SSC/SAM code and samples, but will affect any SDK/PySAM code out in the world that refers to those outputs. |
Fixes NREL/SAM#1879
Goes with NREL/SAM#2009, see that PR for details.