-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gb/optm state #242
Gb/optm state #242
Conversation
… output at end of epoch to history
… could underestimate changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Any interesting results yet?
not really, i think we'll need more training time to see if there's a trajectory. Some layers are definitely gaining momentum on gradients but not sure if they'll converge. |
ef77b81
to
0bc3f6c
Compare
0bc3f6c
to
5134c3e
Compare
sup3r/preprocessing/cachers/base.py
Outdated
f'received error: "{e}"') | ||
logger.warning(msg) | ||
warn(msg) | ||
ncfile.setncattr(attr_name, json.dumps(attr_value)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnb32 fyi i was getting a weird error in production runs where the model meta data had objects that were not compatible with NetCDF. I added some extra error handling here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grantbuster ok cool. I removed some of the default serializing I had before bc it was casting too many things to strings, guess I removed too many. you should use the safe_serialize
function:
sup3r/sup3r/utilities/utilities.py
Line 69 in e43e4bb
def safe_serialize(obj, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart, done!
…ta as attrs, needs to be serialized another way, added error handling here
5134c3e
to
a74ed5c
Compare
No description provided.