Gb/disc valid #246
Merged
Gb/disc valid #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zeros can corrupt images
bnb32
approved these changes
Nov 20, 2024
Yeah this is a great point. The typical use case for the solar model (few timesteps) makes this definitely worth doing. |
grantbuster
force-pushed
the
gb/disc_valid
branch
2 times, most recently
from
8124053
to
f14719b
Compare
grantbuster
force-pushed
the
gb/disc_valid
branch
from
f14719b
to
bfcb69c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bnb32 fyi i started this yesterday and already see good results with the solar model that has a small number of timesteps passed to the disc. This makes a ton of sense since stride=2 for a lot of the conv layers in disc, which will compress the image significantly and padding zeros will have an outsized effect on the small solar observation. The effect will become negligible as the observation size grows but i still think this is a worthwhile improvement.