-
Notifications
You must be signed in to change notification settings - Fork 164
Fix typos found by codespell #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Not sure about I believe it's OK because it's a private variable. |
We own most of Contrib. If there is anything upstream I'll deal with it. |
Fixed typos in |
I have left out There may be a few starting comments in English to fix, for example Should I fix these comments? Edit: That's actually the only typo in there; I have fixed it. |
And I just noticed part of the initial fixes, under Edit: I've sent a mail to the upstream maintainer. |
Bulletted only has 35k hits on Google vs millions for Bulleted. I'll take the fix. |
I see you have merged this change into the Subversion trunk. Thanks! Would it be worth adding a configuration file |
I suppose that depends on how many false-positives you had to deal with and what the maintenance overhead is... |
I am afraid nsis has many false positives: $ codespell | wc -l
954
$ Most of them are in translation files that should be skipped. A $ codespell --skip 'Language files' | wc -l
226
$ The can further reduce that number by ignoring some words: $ codespell --skip 'Language files' --ignore-words-list parms | wc -l
133
$ The benefit of a |
Fix last typos in the process. About "everytime" see for example: https://www.grammarly.com/blog/everytime-every-time/
All fixes have been merged, thank you. I have added a |
Some typos are in user-visible strings and documentation, others are in code comments.
In the long term, I recommend fixing all typos, including those in code comments, because tools like codespell do not make a difference between code comments and documentation and user-visible strings.
I have left out typos in
Contrib
, they should be fixed upstream.