Skip to content

Commit

Permalink
Minor tweaks and addressing review comments from PR#2
Browse files Browse the repository at this point in the history
  • Loading branch information
mrakitin committed Feb 22, 2024
1 parent 9c9f539 commit 590e554
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Set env vars
run: |
set -x
export REPOSITORY_NAME=${GITHUB_REPOSITORY#*/} # just the repo, as opposed to org/repo
echo "REPOSITORY_NAME=${REPOSITORY_NAME}" >> $GITHUB_ENV
Expand Down
4 changes: 3 additions & 1 deletion scripts/run-act.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#!/bin/bash

act -W .github/workflows/ci.yml -j checks --matrix python-version:3.11
PYTHON_VERSION="${1:-3.11}"

act -W .github/workflows/ci.yml -j checks --matrix python-version:"${PYTHON_VERSION}"
5 changes: 1 addition & 4 deletions scripts/test-file-saving.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ fi
num="${1:-50}"

data_dir="/tmp/test/$(date +%Y/%m/%d)"

if [ ! -d "${data_dir}" ]; then
mkdir -v -p "${data_dir}"
fi
mkdir -v -p "${data_dir}"

caput "BASE:{Dev:Save1}:write_dir" "${data_dir}"
caput "BASE:{Dev:Save1}:file_name" "saveme_{num:06d}_{uid}.h5"
Expand Down
2 changes: 1 addition & 1 deletion src/srx_caproto_iocs/example/ophyd.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


class OphydChannelTypes(Device):
"""An ophyd Device which works with the CaprotoIOCChannelTypes caproto IOC."""
"""An ophyd Device which works with the CaprotoStringIOC caproto IOC."""

bare_string = Cpt(EpicsSignal, "bare_string", string=True)
implicit_string_type = Cpt(EpicsSignal, "implicit_string_type", string=True)
Expand Down

0 comments on commit 590e554

Please sign in to comment.