Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add suid to filename formatter #3

Merged
merged 3 commits into from
Feb 17, 2024
Merged

add suid to filename formatter #3

merged 3 commits into from
Feb 17, 2024

Conversation

hyperrealist
Copy link
Contributor

Adding a suid option to filename formatter here:

srx-caproto-iocs/src/srx_caproto_iocs/base.py

Lines 132 to 134 in 69d4306

full_file_path = write_dir / file_name.format(
num=self.frame_num.value, uid=uid
)

@hyperrealist
Copy link
Contributor Author

PR is ready to be reviewed @mrakitin

mrakitin
mrakitin approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, @hyperrealist! Thank you.

@mrakitin mrakitin merged commit f63e243 into NSLS-II-SRX:add-zebra-ioc Feb 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperrealist @mrakitin