imports & params commented out from V1 release - can we delete or not? #44
Labels
_commonspeckle
part of V2, but strictly related to a common repo (speckle + maybe scattering)
_futurepyCHX
part of V2, future pyCHX once XPCS/speckle analysis is fully separated
question
V2
required to move towards share XPCS/speckle analysis for CHX/CSX
This is a place holder to address lines of code that were commented out of V1. Are these lines used as on-the-fly configurations or can they be deleted?
SO far, V2 commented out can be differentiated from V1 commented out because the line will end with
#common
. For example inv2._commonspeckle.chx_xpcs_xsvs_jupyter_V1
:Lines 3, 4 & 5
were commit and released before V2 began.line 5
lines 3 & 4
Line 1
was commented out after import from V2 was set up.First, we need to generate a report so someone knowledgeable can review the code. @ambarb will do that below, so assigning to her for now.
The text was updated successfully, but these errors were encountered: