Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports & params commented out from V1 release - can we delete or not? #44

Open
ambarb opened this issue Oct 15, 2020 · 0 comments
Open
Assignees
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Oct 15, 2020

This is a place holder to address lines of code that were commented out of V1. Are these lines used as on-the-fly configurations or can they be deleted?

SO far, V2 commented out can be differentiated from V1 commented out because the line will end with #common. For example in v2._commonspeckle.chx_xpcs_xsvs_jupyter_V1:

   1 #from pyCHX.v2._commonspeckle.chx_packages import * #common
   2 from pyCHX.v2._commonspeckle.chx_libs import markers, colors #common #TODO all other instances import with ()
   3 #from pyCHX.chx_generic_functions import get_short_long_labels_from_qval_dict
   4 #RUN_GUI = False
   5 #from pyCHX.chx_libs import markers
   6 import pandas as pds
   7 
  • Lines 3, 4 & 5 were commit and released before V2 began.
    • Seems can delete line 5
    • Don't know about lines 3 & 4
  • Line 1 was commented out after import from V2 was set up.

First, we need to generate a report so someone knowledgeable can review the code. @ambarb will do that below, so assigning to her for now.

@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Oct 15, 2020
@ambarb ambarb self-assigned this Oct 15, 2020
@ambarb ambarb changed the title [v1] & [v2] imports & parameters comment out from V1 release - can delete or used as on-the-fly configurations? imports & params commented out from V1 release - can we delete or not? Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) _futurepyCHX part of V2, future pyCHX once XPCS/speckle analysis is fully separated question V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

1 participant