Add container-canary. #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The container does not build: |
danielballan
force-pushed
the
canary
branch
3 times, most recently
from
1a9b772
to
c3abb9a
Compare
I wasn't copying the |
|
Now canary is running, but its checks fail. My guess is that the container has some dependencies (a database?) without which it may not start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conatiner-canary to validate images on PR or release, before publishing.
This is modeled on the setup used in Tiled.
Note that if
/is protected by an API key, a valid API key will need to be added here. I suppose it may also need a Mongo container running....https://github.com/stuartcampbell/nsls2api/pull/6/files#diff-0699ff2a471369440b57203f855a77ca56d48dd98bbd11997fdcd144e150bba8R12-R14