Add endpoint and function to set the current operating cycle #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padraic-shafer
requested changes
May 1, 2024
Comment on lines
+122
to
+131
| if previous_cycle is not None: | ||
| await previous_cycle.set({Cycle.is_current_operating_cycle: False}) | ||
|
|
||
| await new_current_cycle.set({Cycle.is_current_operating_cycle: True}) | ||
|
|
||
| # Let's now check all is well with the world | ||
| expected_current_cycle = await current_operating_cycle(facility) | ||
| if str(expected_current_cycle) != cycle: | ||
| logger.error(f"Failed to set the current operating cycle for {facility} to be {cycle}.") | ||
| return None |
There was a problem hiding this comment.
This should probably packaged into a transaction (or at least use some context manager) to rollback on failure and avoid an inconsistent state.
The test at the end could be removed at that point.
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
Co-authored-by: Padraic Shafer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have restricted access to the endpoint to admin API keys