Add endpoint to create slack channel for a given proposal #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the SlackChannelManagersView model to the beamlines.py file in the src/nsls2api/models directory. The model includes a list of slack_channel_managers and a projection setting for the corresponding database field. This model will be used to manage the Slack channel managers for each beamline.
The commit adds a new endpoint `/beamline/{name}/slack-channel-managers` to the `beamline_api.py` file in the `src/nsls2api/api/v1` directory. This endpoint allows users to retrieve the Slack channel managers for a specific beamline. If the beamline is not found, a 404 error is returned.
This commit adds the SlackUser model to the `slack_models.py` file in the `src/nsls2api/models` directory. The model includes fields for `user_id`, `username`, and `email`. This model will be used to represent a Slack user in the application.
This commit adds functionality to retrieve the Slack user IDs of the channel managers for a given beamline. It introduces a new function `slack_channel_managers` in the `beamline_service.py` file. The function takes the name of the beamline as input and returns a list of Slack user IDs. It also includes necessary error handling if the beamline is not found.
Also added various docs
stuartcampbell
commented
May 11, 2024
| ) | ||
|
|
||
| # TODO: Uncomment to actually add the users when we are sure!! | ||
| # slack_service.add_users_to_channel(channel_id=channel_id, user_ids=proposal_user_ids) |
There was a problem hiding this comment.
This is the line that needs to be uncommented to add all the users to the slack channel
…d description parameter.
Co-authored-by: Padraic Shafer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endpoint to create a Slack channel for a proposal.
It will add the "bot" to the channel and then add all the beamline slack managers and all the proposal users that have a valid username.
Also added an endpoint for the beamline to list the slack channel managers
Note: currently the line to actually add external users is commented out until we are sure this works ok.