Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use github workflow for redis server #9

Merged
merged 6 commits into from
Feb 22, 2024
Merged

use github workflow for redis server #9

merged 6 commits into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. use github workflow for redis server 

     * remove fixture that uses subprocess
 * remove server fixture from tests
 * tests pass when using local conda env and redis server
    @JunAishima
    JunAishima committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    efde368 View commit details
    Browse the repository at this point in the history

  2. ensure that redis is clean before using

    @JunAishima
    JunAishima committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1276164 View commit details
    Browse the repository at this point in the history

  3. enable changing of host for redis 

     * normally would be localhost, but enable local
   testing with a different host
 * makes it symmetric with the port definition
    @JunAishima
    JunAishima committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1103b37 View commit details
    Browse the repository at this point in the history

  4. use the environment variable correctly

    @JunAishima
    JunAishima committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    445c4d1 View commit details
    Browse the repository at this point in the history

  5. add flag to prevent doing redis server flushall() 

     * prevent non-test instances from being wiped clean
    @JunAishima
    JunAishima committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    caebf42 View commit details
    Browse the repository at this point in the history

  6. Update tests/conftest.py 

    Co-authored-by: Dan Allan <[email protected]>
    @JunAishima @danielballan
    JunAishima and danielballan authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c6fd79e View commit details
    Browse the repository at this point in the history