Spans Everywhere Part 1 #973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cure() | ||
| return | ||
| if (prob(8)) | ||
| affected_mob << "\red Your head hurts." | ||
| affected_mob << "<span class='warning'>our head hurts.</span>" |
There was a problem hiding this comment.
Your --became--> Our
|
I got as far as APC.dm I'll review more another day, I'm tired (Just got back from Niece's birthday party) |
|
I think we should add this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces \red and \blue in 50 files with span classes. The number of file changes started to get ridiculously high so I'm only doing about 50 file changes per PR, which is still ridiculous. Each commit contains 10 files each, to make things a little easier. I'm 90% certain I've made a mistake or two, so it'd be worth checking for mistakes. Otherwise, this is ready to go.