Task/fix grant redirect on slug change #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
i put in a short name that violated rules (had a character, !, that's not allowed) and when i clicked Update it gave me an error (expected behavior). then i went back and changed the short name to something that was acceptable but when i clicked Update another time, it gave me the same error and in the URL i could see it was using the incorrect short name (the one with the !). then i tried it again, editing the short name to the same acceptable one, and it finally "took". error message i got when short name was: https://[host[/grants/againagain! You may have mistyped the address or the page may have moved. [Visit the homepage to see a list of current grants.] |
|
I think this is due to norman/friendly_id#1012 |
jseraf
added a commit
that referenced
this pull request
Jul 9, 2024
* Task/submission review assignments (#1046) * WIP: misc formatting, typos, cleanup * WIP: add modal to layout * WIP: add modal controller * WIP: add assign review modal * WIP: Use modal on grant submissions index * WIP: remove policy scope from submissions controller * WIP: add submission.eligible_reviewers specs * WIP: update submission index specs * WIP: display explanation when reviewer/review limits reached * WIP: resolve merge conflict * WIP: additional modal close options * Redirect opt-out reviewer to grant, update specs (#1047) * Move modal frame to a partial (#1048) * Update jquery-ui-rails gem (#1049) * Task/rework reviewer assignment page (#1053) * Redesign reviewer tab and review assignment process * Add assignment of reviews to the Submission page * Task/update manage links (#1055) * Update manage grant links * Add specs for panel and permissions links * WIP: remove condition for edit link display * Task/fix grant redirect on slug change (#1056) * Reload grant on edit to get current friendly url * WIP: add friendly url spec, remove instance variables * WIP: rubocop refactor, code and comment cleanup * WIP: add draft banner specs * Task/misc updates (#1057) * WIP: removed unused scope * WIP: delete unused partial * WIP: Clarify tool tip text for score count and scores * WIP: Remove unused css file * WIP: prevent page bouncing on clear file button click * WIP: remove file clear button after click * Reduce n+1 queries on panel page * Bump rails, hotwire * Add stimulus controller to Remove disallowed characters from slug input * Hide assign review on Submission index after review period * Code cleanup * Bump version, update release notes
Merged
jseraf
added a commit
that referenced
this pull request
Jul 10, 2024
* Task/submission review assignments (#1046) * WIP: misc formatting, typos, cleanup * WIP: add modal to layout * WIP: add modal controller * WIP: add assign review modal * WIP: Use modal on grant submissions index * WIP: remove policy scope from submissions controller * WIP: add submission.eligible_reviewers specs * WIP: update submission index specs * WIP: display explanation when reviewer/review limits reached * WIP: resolve merge conflict * WIP: additional modal close options * Redirect opt-out reviewer to grant, update specs (#1047) * Move modal frame to a partial (#1048) * Update jquery-ui-rails gem (#1049) * Task/rework reviewer assignment page (#1053) * Redesign reviewer tab and review assignment process * Add assignment of reviews to the Submission page * Task/update manage links (#1055) * Update manage grant links * Add specs for panel and permissions links * WIP: remove condition for edit link display * Task/fix grant redirect on slug change (#1056) * Reload grant on edit to get current friendly url * WIP: add friendly url spec, remove instance variables * WIP: rubocop refactor, code and comment cleanup * WIP: add draft banner specs * Task/misc updates (#1057) * WIP: removed unused scope * WIP: delete unused partial * WIP: Clarify tool tip text for score count and scores * WIP: Remove unused css file * WIP: prevent page bouncing on clear file button click * WIP: remove file clear button after click * Reduce n+1 queries on panel page * Bump rails, hotwire * Add stimulus controller to Remove disallowed characters from slug input * Hide assign review on Submission index after review period * Code cleanup * Bump version, update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1051
Fixes redirect on change to the grant's friendly URL.