Basic implementation of TikTok embeds #782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrol the height, so the embed overflows, which is annoying.
|
After fooling around in the browser inspector, it seems like it's things in the embed which force the height to 740px. Since we can't control the internals, it seems that people will simply have to tolerate that the tiktok embed will, in most cases, overflow the "StorySlider" and the bottom will be covered by the navigation component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #781
The embeds basically work, although there is a painfully long lag in loading, and there doesn't seem to be any way to control the height of the embed, which means it overflows the available space on a typical timeline.
Will let this sit for a little to see if we (or anyone watching!) can figure those out, but I don't think they're blockers to integrating it.