Simplify thrust invocations #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-128 |
|
Step 2 in to actually fix: #126 |
bashimao
force-pushed
the
simplify-thrust-invocations
branch
from
a3b4ab4 to
40cd796
Compare
|
Updated. |
rhdong
reviewed
May 30, 2023
| @@ -327,7 +321,7 @@ class HashTable { | |||
| reinterpret_cast<uintptr_t*>(d_dst)); | |||
| thrust::device_ptr<int> d_src_offset_ptr(d_src_offset); | |||
|
|
|||
| thrust::sort_by_key(thrust_par.on(stream), d_dst_ptr, d_dst_ptr + n, | |||
| thrust::sort_by_key(thrust::cuda::par_nosync.on(stream), d_dst_ptr, d_dst_ptr + n, | |||
There was a problem hiding this comment.
No need to change here. Currently, we can get successfully compile on both A100 and TH500.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the thrust dependency is fixed (and updated to a newer version), we can remove the boilerplate code we had before.