Make padding op faster and add error check #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
reviewed
May 11, 2023
| row_ranges.extend(array_lib.arange(int(starts[idx]), int(ends[idx]))) | ||
| row_ranges = array_lib.concatenate( | ||
| list(map(functools.partial(get_arange, array_lib), starts, ends)) | ||
| ) |
karlhigley
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes the loop creating the range of individual indices for each value to be added to the padded array with a map function in order to make it faster. This PR also adds a check to ensure that the padding size selected by user fits the data. If the data has any records that are bigger than the padding size, we raise a value error. This op is for padding only, it does not incorporate list slice.