Skip to content

Conversation

AAnoosheh
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Update get_tensor_shapes function whose signature was refactored

Collection: LLM

Changelog

  • Update get_tensor_shapes function whose signature was refactored

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@AAnoosheh
Copy link
Collaborator Author

AAnoosheh commented Aug 28, 2025

@chtruong814 I forgot your other MR #14568 wasn't merged to update MCore when I ran CICD.

But how did that one pass now?

EDIT: Oh I see I think you bumped it to a version where that function signature didn't change!
Do we put this MR on hold until later?

@chtruong814
Copy link
Collaborator

@AAnoosheh we can do the Mcore bump here. Let me push a commit to see if it fixes it.

@chtruong814 chtruong814 added r2.5.0 Cherry-pick label for the 2.5.0 release Run CICD and removed Run CICD labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r2.5.0 Cherry-pick label for the 2.5.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants