Skip to content

Conversation

kevalmorabia97
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 commented Sep 5, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

  • Bump modelopt to 0.35.0 (platform independent wheel from now on so no need for safe_import)
  • Also unblocks nemo1 deprecation where pruning test was failing with old modelopt

Collection: llm

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/modelopt-0.35 branch 2 times, most recently from 9827329 to 6478113 Compare September 5, 2025 06:16
@kevalmorabia97 kevalmorabia97 changed the title Bump modelopt to 0.35.0 Bump modelopt to 0.35.0 and remove safe_import("modelopt") Sep 5, 2025
dimapihtar
dimapihtar previously approved these changes Sep 5, 2025
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@kevalmorabia97 kevalmorabia97 changed the title Bump modelopt to 0.35.0 and remove safe_import("modelopt") Bump modelopt to 0.35.0 and remove safe_import("modelopt") in llm collection Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants