Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FusionExector to KernelExecutor, fe to ke, fec to executor_cache #3349

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Rename FusionExector to KernelExecutor, fe to ke, fec to executor_cache #3349

merged 7 commits into from
Nov 7, 2024
+3,684 −3,458

Conversation

naoyam
Copy link
Collaborator

@naoyam naoyam commented Nov 5, 2024

This is just mechanical name change only. Intended to simplify #3263.

@naoyam
Copy link
Collaborator Author

naoyam commented Nov 5, 2024

!test

@naoyam naoyam requested a review from csarofeen November 5, 2024 20:36
@naoyam
Copy link
Collaborator Author

naoyam commented Nov 5, 2024

!test

1 similar comment
@naoyam
Copy link
Collaborator Author

naoyam commented Nov 5, 2024

!test

@naoyam
Copy link
Collaborator Author

naoyam commented Nov 5, 2024

Changed lines after this PR:

+2,614 −2,216

https://github.com/NVIDIA/Fuser/pull/3351/files

@naoyam
Copy link
Collaborator Author

naoyam commented Nov 5, 2024

!test

@naoyam
Copy link
Collaborator Author

naoyam commented Nov 7, 2024

!build

@naoyam naoyam merged commit ba4f7d4 into main Nov 7, 2024
15 checks passed
@naoyam naoyam deleted the rename branch November 7, 2024 01:19
This was referenced Nov 7, 2024
Open
Merged
naoyam added a commit that referenced this pull request Nov 7, 2024
@naoyam
Renaming from #3263 part2 (#3362)
951dde6 
Follow-up to #3349 

`KernelExecutor::compileFusion` -> `KernelExecutor::compile`
`KernelExecutor::runFusion` -> `KernelExecutor::run`
wujingyue added a commit that referenced this pull request Nov 7, 2024
@wujingyue
Redo #3326.
77a8db7 
The change was accidentally reverted in
#3349.
@wujingyue wujingyue mentioned this pull request Nov 7, 2024
Merged
wujingyue added a commit that referenced this pull request Nov 7, 2024
@wujingyue
Redo #3326. (#3370)
e072c92 
The change was accidentally reverted in
#3349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wujingyue wujingyue wujingyue approved these changes

@csarofeen csarofeen Awaiting requested review from csarofeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naoyam @wujingyue