-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize scheduler: enable vectorization #3694
Conversation
Currently only has one parameter
…ed_enabled' into resize_scheduler_test
…r_update_heuristic
may not be a valid path from loop IDs
…ds' into resize_scheduler_test
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// slicing paths as well. For now, in order to avoid the error due | ||
// to issue #3640, use a size that is divisible by 8. | ||
// std::vector<int64_t> shape({16, 100}); | ||
std::vector<int64_t> shape({16, 96}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjsjann123 Forgot to include this WAR. This is what I mentioned to you that I saw an error due to #3640.
!test |
!test |
!test |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
!test |
Stacked on #3693
This PR adds a preliminary vectorization support to the resize scheduler. It currently only considers vectorization of the innermost dimension, just because that's good enough for the RoPE cases. It should eventually be extended to support vectorizing multiple innermost dimensions.