Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lint/flake8 happy #3949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make lint/flake8 happy #3949

wants to merge 1 commit into from

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue wujingyue requested a review from zasdfgbnm February 23, 2025 18:47
@wujingyue
Copy link
Collaborator Author

!test

Copy link

Description

  • Improved code readability by adding spaces around operators

Changes walkthrough 📝

Relevant files
Formatting
run_nvfuser_tests.py
Add spaces around division operators                                         

tools/run_nvfuser_tests.py

  • Added spaces around division operators for better readability
+4/-4     

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
⚡ Recommended focus areas for review

Code Duplication

The same calculation timeout / 60 is repeated multiple times. Consider defining a variable for this calculation to avoid duplication.

if dry_run:
    print(f"Would run: {' '.join(cmd)} (timeout: {timeout / 60} minutes)")
    return True
Code Duplication

The same calculation timeout / 60 is repeated multiple times. Consider defining a variable for this calculation to avoid duplication.

with open(f"{log_base}.log", "w") as f:
    f.write(f"Test: {test_name}\n")
    f.write(f"ERROR: Test timed out after {timeout / 60} minutes\n")
Code Duplication

The same calculation timeout / 60 is repeated multiple times. Consider defining a variable for this calculation to avoid duplication.

# Check for timeout
if time.time() - start_times[gpu_id] > timeout:
    print(
        f"Test {test_name} on GPU {gpu_id} timed out after {timeout / 60} minutes"
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant