Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback handlers in tracing.py #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix callback handlers in tracing.py #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions RAG/src/chain_server/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator

from RAG.tools.observability.langchain import opentelemetry_callback as langchain_otel_cb
from RAG.tools.observability.llamaindex import opentelemetry_callback as llama_index_otel_cb

# Configure tracer used by the Chain Server to create spans
resource = Resource.create({SERVICE_NAME: "chain-server"})
provider = TracerProvider(resource=resource)
Expand All @@ -45,11 +42,37 @@
# Configure Propagator used for processing trace context received by the Chain Server
propagator = TraceContextTextMapPropagator()

# Configure Langchain OpenTelemetry callback handler
langchain_cb_handler = langchain_otel_cb.OpenTelemetryCallbackHandler(tracer)

# Configure LlamaIndex OpenTelemetry callback handler
llama_index_cb_handler = llama_index_otel_cb.OpenTelemetryCallbackHandler(tracer)
# Define Langchain OpenTelemetry callback handler
class LangchainOpenTelemetryCallbackHandler(langchain_base_cb_handler):
def __init__(self, tracer):
super().__init__()
self.tracer = tracer

def on_start(self, *args, **kwargs):
with self.tracer.start_as_current_span("LangchainOperation") as span:
span.set_attributes({"operation": "start"})

def on_end(self, *args, **kwargs):
with self.tracer.start_as_current_span("LangchainOperationEnd") as span:
span.set_attributes({"operation": "end"})

langchain_cb_handler = LangchainOpenTelemetryCallbackHandler(tracer)

# Define LlamaIndex OpenTelemetry callback handler
class LlamaIndexOpenTelemetryCallbackHandler(llama_index_base_cb_handler):
def __init__(self, tracer):
super().__init__()
self.tracer = tracer

def on_start(self, *args, **kwargs):
with self.tracer.start_as_current_span("LlamaIndexOperation") as span:
span.set_attributes({"operation": "start"})

def on_end(self, *args, **kwargs):
with self.tracer.start_as_current_span("LlamaIndexOperationEnd") as span:
span.set_attributes({"operation": "end"})

llama_index_cb_handler = LlamaIndexOpenTelemetryCallbackHandler(tracer)

else:
propagator = CompositePropagator([]) # No-op propagator
Expand Down