Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add release workflow #382

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 6, 2024

What does this PR do ?

This implements the weekly routine of our new dev cycle where we want to publish pre-releases every week. So this workflow:

  1. Creates a tag on main with the current version number (first week after a release it would be rX.Y.Zrc0)
  2. Attempts a version bump of prerelease part via PR (resulting in rX.Y.Zrc1)
  3. Notifies the slack channel

In a follow-up PR, we will add a mechanism that also publishes a pypi wheel with this automation

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Nov 6, 2024

jobs:
prerelease:
uses: NVIDIA/NeMo-FW-CI-templates/.github/workflows/_prerelease_tag.yml@ko3n1g/feat/pre-release-tag
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed to a proper version number after all discussions have been resolved

Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/add-prerelease-tagging-workflow branch from ca428f5 to c67a380 Compare November 7, 2024 10:15
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g changed the title ci: Add prerelease tagging workflow ci: Add release workflow Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant