Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update cherry pick workflow #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 7, 2024

What does this PR do ?

  • Features:
    • Send slack alerts for non-trivial cherry picks
  • Fixed:
    • Label parser matches rX.Y.Z* now instead of r*

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g requested a review from terrykong November 7, 2024 08:24
@github-actions github-actions bot added the CI label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant