Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regular torch optims (e.g., sgd) no longer error with closure spec #11189

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: regular torch optims (e.g., sgd) no longer error with closure spec #11189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f45e8c
fix: regular torch optims (e.g., sgd) no longer error with closure spec
terrykong Nov 6, 2024
965fea0
address style
terrykong Nov 6, 2024
ba8edbd
revert old pop
terrykong Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions nemo/core/optim/optimizer_with_main_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,10 @@ def step(self, **kwargs):
if self._async_grad_allreduce:
torch.cuda.synchronize()

closure = kwargs.pop('closure', None)
# Allows applications to specify closure kwarg without erroring due to duplicate specification
assert closure is None, f"closre should be None but was passed {closure}"

# Step the optimizer.
self.optimizer.step(closure=None, **kwargs)

Expand Down
Loading