Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run Pylint strictly on new files, softly on history #11212

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 7, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <[email protected]>
@github-actions github-actions bot added core Changes to NeMo Core CI labels Nov 7, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
@NVIDIA NVIDIA deleted a comment from github-actions bot Nov 7, 2024
@NVIDIA NVIDIA deleted a comment from github-actions bot Nov 7, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.core.classes.dataset2
nemo/core/classes/dataset2.py:102:0: C0115: Missing class docstring (missing-class-docstring)
************* Module nemo.core.classes.dataset
nemo/core/classes/dataset.py:102:0: C0115: Missing class docstring (missing-class-docstring)
************* Module nemo.core.classes.exportable
nemo/core/classes/exportable.py:41:0: C0301: Line too long (120/119) (line-too-long)
nemo/core/classes/exportable.py:81:0: C0301: Line too long (121/119) (line-too-long)
nemo/core/classes/exportable.py:102:0: C0301: Line too long (120/119) (line-too-long)
nemo/core/classes/exportable.py:53:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:57:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:320:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:324:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:328:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:332:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/core/classes/exportable.py:335:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.36/10

Please help us to raise the code-quality of NeMo!

Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g changed the title Ko3n1g/ci/pylint on new files ci: Run Pylint stricly on new files, softly on history Nov 7, 2024
@ko3n1g ko3n1g changed the title ci: Run Pylint stricly on new files, softly on history ci: Run Pylint strictly on new files, softly on history Nov 7, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant