Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortformer Diarizer 4spk v1 model PR Part 2: Unit-tests for Sortformer Diarizer. #11336

Open
wants to merge 121 commits into
base: main
Choose a base branch
from

Conversation

tango4j
Copy link
Collaborator

@tango4j tango4j commented Nov 20, 2024

What does this PR do ?

This is the second PR that deals with unit tests for
Sortformer Diarizer Model, 4 speaker limit, v1 model.

Previous PR:
This is PR 2nd out of 3.
1st PR: #11336
3rd PR:

Sortformer Paper:
Sortformer Paper Link

Overview:

  • We moved all the speaker recognition related test files from
    NeMo/tests/collections/asr to NeMo/tests/collections/speaker_tasks.
  • We have added all Sortformer diarizer related unit-test functions and classes.

Collection: ASR

Changelog

Updated the test_data.tar.gz file in https://github.com/NVIDIA/NeMo/releases/tag/v1.0.0rc1

NeMo/tests/collections/speaker_tasks/.
├── test_diar_datasets.py (moved, modified)
├── test_diar_label_models.py (moved, modified)
├── test_diar_lhotse_datasets.py (created)
├── test_diar_metrics.py (moved, modified)
├── test_diar_neural_inference.py (moved, modified) 
├── test_diar_sortformer_models.py (created)
├── test_speaker_label_models.py (moved)
└── utils
    ├── test_data_simul_utils.py (moved)
    ├── test_diar_utils.py (moved)
    ├── test_multispeaker_utils.py (created)
    └── test_vad_utils.py (moved)

Usage

pytest <NeMo Root>/tests/collections/speaker_tasks/*

GitHub Actions CI

Added the new CIs for Sortformer Diarizer.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

tango4j and others added 30 commits November 13, 2024 18:46
Signed-off-by: taejinp <[email protected]>
@github-actions github-actions bot added the ASR label Nov 29, 2024
@tango4j tango4j marked this pull request as ready for review November 29, 2024 13:36
@tango4j tango4j added Run CICD and removed Run CICD labels Nov 29, 2024
@tango4j tango4j added Run CICD and removed Run CICD labels Dec 2, 2024
@tango4j tango4j added Run CICD and removed Run CICD labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant