Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean write_on_batch_end #11454

Closed
wants to merge 2 commits into from
Closed

clean write_on_batch_end #11454

wants to merge 2 commits into from

Conversation

orena1
Copy link
Contributor

@orena1 orena1 commented Dec 3, 2024

No need to repeat all the lines
@pzelasko I think relevant to you

No need to repeat all the lines

Signed-off-by: Oren Amsalem <[email protected]>
@github-actions github-actions bot added the ASR label Dec 3, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 17, 2024
@orena1
Copy link
Contributor Author

orena1 commented Dec 17, 2024

@pzelasko did you have a check to look?

@github-actions github-actions bot removed the stale label Dec 18, 2024
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.asr.data.audio_to_text_dataset
nemo/collections/asr/data/audio_to_text_dataset.py:252:0: C0301: Line too long (148/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:339:0: C0301: Line too long (175/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:433:0: C0301: Line too long (173/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:505:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:556:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:907:0: C0301: Line too long (130/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:919:0: C0301: Line too long (127/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:927:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:941:0: C0301: Line too long (149/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:953:0: C0301: Line too long (152/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:979:0: C0301: Line too long (126/119) (line-too-long)
nemo/collections/asr/data/audio_to_text_dataset.py:405:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:845:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:852:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:891:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:896:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:914:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/asr/data/audio_to_text_dataset.py:945:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.46/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 8, 2025
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant