Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Llama3 Fine-Tuning Notebook #11522

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

roclark
Copy link
Member

@roclark roclark commented Dec 9, 2024

What does this PR do ?

Update the Llama3-8B PubMeQA fine-tuning example notebook for a seamless experience.

Collection: NLP

Changelog

  • Fix an issue where using a base model with an older Transformer Engine version would cause a crash indicating missing model weight files.
  • Download the model directly from NGC in the notebook for a full end-to-end example.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Update the Llama3-8B PubMeQA fine-tuning example notebook with the following:
* Fix an issue where using a base model with an older Transformer Engine version would cause a crash indicating missing model weight files.
* Download the model directly from NGC in the notebook for a full end-to-end example.

Signed-Off-By: Robert Clark <[email protected]>
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 8583201 into NVIDIA:main Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants